chore: resolve PR comments

Author: micaelae

packages/transaction-controller/CHANGELOG.md

@@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
-- Preserve type of nested transactions in batch if specified in `TransactionBatchSingleRequest` ([#6056](https://github.com/MetaMask/core/pull/6056))
+- Preserve provided `type` in `transactions` when calling `addTransactionBatch` ([#6056](https://github.com/MetaMask/core/pull/6056))
 
 ## [58.1.0]
 

packages/transaction-controller/src/utils/batch.test.ts

@@ -908,34 +908,12 @@ describe('Batch Utils', () => {
         await flushPromises();
 
         expect(publishBatchHook).toHaveBeenCalledTimes(1);
-        expect(publishBatchHook).toHaveBeenCalledWith({
-          from: FROM_MOCK,
-          networkClientId: NETWORK_CLIENT_ID_MOCK,
-          transactions: [
-            {
-              id: TRANSACTION_ID_MOCK,
-              params: {
-                ...TRANSACTION_BATCH_PARAMS_MOCK,
-                gas: undefined,
-                maxFeePerGas: undefined,
-                maxPriorityFeePerGas: undefined,
-              },
-              signedTx: TRANSACTION_SIGNATURE_MOCK,
-              type: TransactionType.swap,
-            },
-            {
-              id: TRANSACTION_ID_2_MOCK,
-              params: {
-                ...TRANSACTION_BATCH_PARAMS_MOCK,
-                gas: undefined,
-                maxFeePerGas: undefined,
-                maxPriorityFeePerGas: undefined,
-              },
-              signedTx: TRANSACTION_SIGNATURE_2_MOCK,
-              type: TransactionType.bridge,
-            },
-          ],
-        });
+        expect(publishBatchHook.mock.calls[0][0].transactions[0]).toBe(
+          TransactionType.swap,
+        );
+        expect(publishBatchHook.mock.calls[0][0].transactions[1]).toBe(
+          TransactionType.bridge,
+        );
       });
 
       it('resolves individual publish hooks with transaction hashes from publish batch hook', async () => {

packages/transaction-controller/src/utils/batch.ts

@@ -246,16 +246,17 @@ async function getNestedTransactionMeta(
   ethQuery: EthQuery,
 ): Promise<NestedTransactionMetadata> {
   const { from } = request;
-  const { params, type: requestType } = singleRequest;
+  const { params, type: requestedType } = singleRequest;
 
-  const { type } = await determineTransactionType(
+  const { type: determinedType } = await determineTransactionType(
     { from, ...params },
     ethQuery,
   );
 
+  const type = requestedType ?? determinedType;
   return {
     ...params,
-    type: requestType ?? type,
+    type,
   };
 }