Skip to content

Commit ea548ac

Browse files
Merge pull request #461 from yihui/summary-cleanup
Clean up `summary` functions
2 parents 7a6ebb0 + 9ba6c87 commit ea548ac

17 files changed

+209
-544
lines changed

NAMESPACE

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ importFrom(dplyr,left_join)
7575
importFrom(dplyr,mutate)
7676
importFrom(dplyr,one_of)
7777
importFrom(dplyr,rename)
78+
importFrom(dplyr,row_number)
7879
importFrom(dplyr,select)
7980
importFrom(dplyr,summarize)
8081
importFrom(dplyr,ungroup)
@@ -83,6 +84,7 @@ importFrom(gsDesign,sfLDOF)
8384
importFrom(mvtnorm,GenzBretz)
8485
importFrom(stats,pnorm)
8586
importFrom(stats,qnorm)
87+
importFrom(stats,setNames)
8688
importFrom(stats,stepfun)
8789
importFrom(stats,uniroot)
8890
importFrom(survival,Surv)

R/as_gt.R

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,11 @@ as_gt.fixed_design <- function(x, title = NULL, footnote = NULL, ...) {
8989
return(ans)
9090
}
9191

92+
get_method <- function(x, methods) intersect(methods, class(x))[1]
93+
9294
# get the fixed design method
9395
fd_method <- function(x) {
94-
methods <- c("ahr", "fh", "mb", "lf", "rd", "maxcombo", "milestone", "rmst")
95-
intersect(methods, class(x))[1]
96+
get_method(x, c("ahr", "fh", "mb", "lf", "rd", "maxcombo", "milestone", "rmst"))
9697
}
9798

9899
# get the default title

R/gsDesign2-package.R

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,7 @@
1717
# along with this program. If not, see <http://www.gnu.org/licenses/>.
1818

1919
#' @keywords internal
20-
"_PACKAGE"
21-
2220
#' @useDynLib gsDesign2, .registration = TRUE
23-
NULL
24-
21+
#' @importFrom stats setNames
2522
#' @importFrom Rcpp sourceCpp
26-
NULL
23+
"_PACKAGE"

R/gs_design_ahr.R

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -380,10 +380,6 @@ gs_design_ahr <- function(
380380
analysis = analysis
381381
)
382382

383-
class(ans) <- c("ahr", "gs_design", class(ans))
384-
if (!binding) {
385-
class(ans) <- c("non_binding", class(ans))
386-
}
387-
383+
ans <- add_class(ans, if (!binding) "non_binding", "ahr", "gs_design")
388384
return(ans)
389385
}

R/gs_design_rd.R

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -281,10 +281,6 @@ gs_design_rd <- function(p_c = tibble::tibble(stratum = "All", rate = .2),
281281
analysis = analysis
282282
)
283283

284-
class(ans) <- c("rd", "gs_design", class(ans))
285-
if (!binding) {
286-
class(ans) <- c("non_binding", class(ans))
287-
}
288-
284+
ans <- add_class(ans, if (!binding) "non_binding", "rd", "gs_design")
289285
return(ans)
290286
}

R/gs_design_wlr.R

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -268,10 +268,6 @@ gs_design_wlr <- function(
268268
analysis = analysis
269269
)
270270

271-
class(ans) <- c("wlr", "gs_design", class(ans))
272-
if (!binding) {
273-
class(ans) <- c("non_binding", class(ans))
274-
}
275-
271+
ans <- add_class(ans, if (!binding) "non_binding", "wlr", "gs_design")
276272
return(ans)
277273
}

R/gs_power_ahr.R

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -280,10 +280,6 @@ gs_power_ahr <- function(
280280
analysis = analysis
281281
)
282282

283-
class(ans) <- c("ahr", "gs_design", class(ans))
284-
if (!binding) {
285-
class(ans) <- c("non_binding", class(ans))
286-
}
287-
283+
ans <- add_class(ans, if (!binding) "non_binding", "ahr", "gs_design")
288284
return(ans)
289285
}

R/gs_power_rd.R

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -348,10 +348,6 @@ gs_power_rd <- function(
348348
analysis = analysis
349349
)
350350

351-
class(ans) <- c("rd", "gs_design", class(ans))
352-
if (!binding) {
353-
class(ans) <- c("non_binding", class(ans))
354-
}
355-
351+
ans <- add_class(ans, if (!binding) "non_binding", "rd", "gs_design")
356352
return(ans)
357353
}

R/gs_power_wlr.R

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -306,11 +306,7 @@ gs_power_wlr <- function(enroll_rate = define_enroll_rate(duration = c(2, 2, 10)
306306
analysis = analysis
307307
)
308308

309-
class(ans) <- c("wlr", "gs_design", class(ans))
310-
if (!binding) {
311-
class(ans) <- c("non_binding", class(ans))
312-
}
313-
309+
ans <- add_class(ans, if (!binding) "non_binding", "wlr", "gs_design")
314310
return(ans)
315311
}
316312

0 commit comments

Comments
 (0)