Corrupt MPF causes mediainfo v25.04.20250614 to hang

[hackerfactor]

I have a picture where the MPF entry's start+offset goes beyond the file size.

mediainfo v19.09 works fine.
mediainfo v25.04.20250614 hangs indefinitely.

I've sent the example image to @JeromeMartinez .

[JeromeMartinez]

I can not make it crash with v25.04.20250625, could you test this version?

[hackerfactor]

Same problem. After 30 seconds, I hit Control-C:

$ valgrind mediainfo keep-5f063f3429f03e9fc68246cc3a9d517c3760a2bf
==354964== Memcheck, a memory error detector
==354964== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==354964== Using Valgrind-3.15.0 and LibVEX; rerun with -h for copyright info
==354964== Command: mediainfo keep-5f063f3429f03e9fc68246cc3a9d517c3760a2bf
==354964== 
^C==354964== 
==354964== Process terminating with default action of signal 2 (SIGINT)
==354964==    at 0x496C30A: ??? (in /usr/lib/x86_64-linux-gnu/libmediainfo.so.0.0.0)
==354964==    by 0x497A5BE: ??? (in /usr/lib/x86_64-linux-gnu/libmediainfo.so.0.0.0)
==354964==    by 0x4B567D7: ??? (in /usr/lib/x86_64-linux-gnu/libmediainfo.so.0.0.0)
==354964==    by 0x4972009: ??? (in /usr/lib/x86_64-linux-gnu/libmediainfo.so.0.0.0)
==354964==    by 0x4972DD1: ??? (in /usr/lib/x86_64-linux-gnu/libmediainfo.so.0.0.0)
==354964==    by 0x4972F3F: ??? (in /usr/lib/x86_64-linux-gnu/libmediainfo.so.0.0.0)
==354964==    by 0x49739CF: ??? (in /usr/lib/x86_64-linux-gnu/libmediainfo.so.0.0.0)
==354964==    by 0x4A23E82: ??? (in /usr/lib/x86_64-linux-gnu/libmediainfo.so.0.0.0)
==354964==    by 0x4F268B2: ??? (in /usr/lib/x86_64-linux-gnu/libmediainfo.so.0.0.0)
==354964==    by 0x4F277A4: ??? (in /usr/lib/x86_64-linux-gnu/libmediainfo.so.0.0.0)
==354964==    by 0x4A100E8: ??? (in /usr/lib/x86_64-linux-gnu/libmediainfo.so.0.0.0)
==354964==    by 0x4F27ECC: ??? (in /usr/lib/x86_64-linux-gnu/libmediainfo.so.0.0.0)
==354964== 
==354964== HEAP SUMMARY:
==354964==     in use at exit: 2,738,234 bytes in 5,954 blocks
==354964==   total heap usage: 16,753 allocs, 10,799 frees, 129,658,127 bytes allocated
==354964== 
==354964== LEAK SUMMARY:
==354964==    definitely lost: 0 bytes in 0 blocks
==354964==    indirectly lost: 0 bytes in 0 blocks
==354964==      possibly lost: 0 bytes in 0 blocks
==354964==    still reachable: 2,738,234 bytes in 5,954 blocks
==354964==         suppressed: 0 bytes in 0 blocks
==354964== Rerun with --leak-check=full to see details of leaked memory
==354964== 
==354964== For lists of detected and suppressed errors, rerun with: -s
==354964== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

Looking at the allocated memory, it was just infinitely allocating in a loop.

I installed:
mediainfo-dbg_25.04.20250625-1_amd64.xUbuntu_20.04.deb
mediainfo_25.04.20250625-1_amd64.xUbuntu_20.04.deb

[g-maxime]

I installed: mediainfo-dbg_25.04.20250625-1_amd64.xUbuntu_20.04.deb mediainfo_25.04.20250625-1_amd64.xUbuntu_20.04.deb

Please also update MediaInfoLib: https://mediaarea.net/download/snapshots/binary/libmediainfo0/20250625-2/libmediainfo0v5_25.04.20250625-1_amd64.xUbuntu_20.04.deb

[hackerfactor]

That fixed it.
Thank you.