Skip to content

Commit def62d0

Browse files
MatthieeMatthiee
committed
Make limit nullable so it doesn't get included in the url when not needed
1 parent 0c1e3d6 commit def62d0

File tree

2 files changed

+54
-27
lines changed

2 files changed

+54
-27
lines changed

‎FinancialModelingPrepApi/Abstractions/CompanyValuation/ICompanyValuation.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,28 +11,28 @@ public interface ICompanyValuation
1111

1212
public Task<ApiResponse<CompanyProfileResponse>> GetCompanyProfileAsync(string symbol);
1313
public Task<ApiResponse<KeyMetricsTTMResponse>> GetCompanyKeyMetricsTTMAsync(string symbol);
14-
public Task<ApiResponse<List<KeyMetricsResponse>>> GetCompanyKeyMetricsAsync(string symbol, Period period = Period.Annual, int limit = 130);
14+
public Task<ApiResponse<List<KeyMetricsResponse>>> GetCompanyKeyMetricsAsync(string symbol, Period period = Period.Annual, int? limit = 130);
1515

1616
public Task<ApiResponse<DCFResponse>> GetDiscountedCashFlowAsync(string symbol);
1717
public Task<ApiResponse<List<HistoricalDCFResponse>>> GetHistoricalDiscountedCashFlowAsync(string symbol, Period period = Period.Annual);
18-
public Task<ApiResponse<List<HistoricalDailyDCFResponse>>> GetHistoricalDiscountedCashFlowDailyAsync(string symbol, int limit = 100);
18+
public Task<ApiResponse<List<HistoricalDailyDCFResponse>>> GetHistoricalDiscountedCashFlowDailyAsync(string symbol, int? limit = 100);
1919

2020
public Task<ApiResponse<MarketCapResponse>> GetMarketCapitalizationAsync(string symbol);
21-
public Task<ApiResponse<List<MarketCapResponse>>> GetHistoricalMarketCapitalizationAsync(string symbol, int limit = 100);
21+
public Task<ApiResponse<List<MarketCapResponse>>> GetHistoricalMarketCapitalizationAsync(string symbol, int? limit = 100);
2222

2323
public Task<ApiResponse<List<SymbolResponse>>> GetSymbolsListAsync();
2424
public Task<ApiResponse<List<SymbolResponse>>> GetTradableSymbolsListAsync();
2525
public Task<ApiResponse<List<SymbolResponse>>> GetETFListAsync();
2626

27-
public Task<ApiResponse<List<EnterpriseValueResponse>>> GetEnterpriseValueAsync(string symbol, Period period = Period.Quarter, int limit = 40);
27+
public Task<ApiResponse<List<EnterpriseValueResponse>>> GetEnterpriseValueAsync(string symbol, Period period = Period.Quarter, int? limit = 40);
2828

29-
public Task<ApiResponse<List<BalanceSheetResponse>>> GetBalanceSheetStatementAsync(string symbol, Period period = Period.Quarter, int limit = 40);
30-
public Task<ApiResponse<List<CashFlowResponse>>> GetCashFlowStatementAsync(string symbol, Period period = Period.Quarter, int limit = 40);
31-
public Task<ApiResponse<List<IncomeStatementResponse>>> GetIncomeStatementAsync(string symbol, Period period = Period.Quarter, int limit = 40);
29+
public Task<ApiResponse<List<BalanceSheetResponse>>> GetBalanceSheetStatementAsync(string symbol, Period period = Period.Quarter, int? limit = 40);
30+
public Task<ApiResponse<List<CashFlowResponse>>> GetCashFlowStatementAsync(string symbol, Period period = Period.Quarter, int? limit = 40);
31+
public Task<ApiResponse<List<IncomeStatementResponse>>> GetIncomeStatementAsync(string symbol, Period period = Period.Quarter, int? limit = 40);
3232

33-
public Task<ApiResponse<List<StockNewsResponse>>> GetStockNewsAsync(string symbol, int limit = 50);
33+
public Task<ApiResponse<List<StockNewsResponse>>> GetStockNewsAsync(string symbol, int? limit = 50);
3434

3535
public Task<ApiResponse<CompanyRatingResponse>> GetCompanyRatingAsync(string symbol);
36-
public Task<ApiResponse<List<CompanyRatingResponse>>> GetHistoricalCompanyRatingAsync(string symbol, int limit = 140);
36+
public Task<ApiResponse<List<CompanyRatingResponse>>> GetHistoricalCompanyRatingAsync(string symbol, int? limit = 140);
3737
}
3838
}

‎FinancialModelingPrepApi/Core/CompanyValuation/CompanyValuation.cs

Lines changed: 45 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public Task<ApiResponse<List<SymbolResponse>>> GetTradableSymbolsListAsync()
7474
return client.GetAsync<List<SymbolResponse>>(url, pathParams, null);
7575
}
7676

77-
public Task<ApiResponse<List<EnterpriseValueResponse>>> GetEnterpriseValueAsync(string symbol, Period period = Period.Quarter, int limit = 40)
77+
public Task<ApiResponse<List<EnterpriseValueResponse>>> GetEnterpriseValueAsync(string symbol, Period period = Period.Quarter, int? limit = 40)
7878
{
7979
const string url = "[version]/enterprise-values/[symbol]";
8080

@@ -86,7 +86,10 @@ public Task<ApiResponse<List<EnterpriseValueResponse>>> GetEnterpriseValueAsync(
8686

8787
var queryString = new QueryStringBuilder();
8888

89-
queryString.Add("limit", limit);
89+
if (limit != null)
90+
{
91+
queryString.Add("limit", limit);
92+
}
9093

9194
if (period == Period.Quarter)
9295
{
@@ -96,7 +99,7 @@ public Task<ApiResponse<List<EnterpriseValueResponse>>> GetEnterpriseValueAsync(
9699
return client.GetAsync<List<EnterpriseValueResponse>>(url, pathParams, queryString);
97100
}
98101

99-
public Task<ApiResponse<List<BalanceSheetResponse>>> GetBalanceSheetStatementAsync(string symbol, Period period = Period.Quarter, int limit = 40)
102+
public Task<ApiResponse<List<BalanceSheetResponse>>> GetBalanceSheetStatementAsync(string symbol, Period period = Period.Quarter, int? limit = 40)
100103
{
101104
const string url = "[version]/balance-sheet-statement/[symbol]";
102105

@@ -108,7 +111,10 @@ public Task<ApiResponse<List<BalanceSheetResponse>>> GetBalanceSheetStatementAsy
108111

109112
var queryString = new QueryStringBuilder();
110113

111-
queryString.Add("limit", limit);
114+
if (limit != null)
115+
{
116+
queryString.Add("limit", limit);
117+
}
112118

113119
if (period == Period.Quarter)
114120
{
@@ -118,7 +124,7 @@ public Task<ApiResponse<List<BalanceSheetResponse>>> GetBalanceSheetStatementAsy
118124
return client.GetAsync<List<BalanceSheetResponse>>(url, pathParams, queryString);
119125
}
120126

121-
public Task<ApiResponse<List<CashFlowResponse>>> GetCashFlowStatementAsync(string symbol, Period period = Period.Quarter, int limit = 40)
127+
public Task<ApiResponse<List<CashFlowResponse>>> GetCashFlowStatementAsync(string symbol, Period period = Period.Quarter, int? limit = 40)
122128
{
123129
const string url = "[version]/cash-flow-statement/[symbol]";
124130

@@ -130,7 +136,10 @@ public Task<ApiResponse<List<CashFlowResponse>>> GetCashFlowStatementAsync(strin
130136

131137
var queryString = new QueryStringBuilder();
132138

133-
queryString.Add("limit", limit);
139+
if (limit != null)
140+
{
141+
queryString.Add("limit", limit);
142+
}
134143

135144
if (period == Period.Quarter)
136145
{
@@ -140,7 +149,7 @@ public Task<ApiResponse<List<CashFlowResponse>>> GetCashFlowStatementAsync(strin
140149
return client.GetAsync<List<CashFlowResponse>>(url, pathParams, queryString);
141150
}
142151

143-
public Task<ApiResponse<List<IncomeStatementResponse>>> GetIncomeStatementAsync(string symbol, Period period = Period.Quarter, int limit = 40)
152+
public Task<ApiResponse<List<IncomeStatementResponse>>> GetIncomeStatementAsync(string symbol, Period period = Period.Quarter, int? limit = 40)
144153
{
145154
const string url = "[version]/income-statement/[symbol]";
146155

@@ -152,7 +161,10 @@ public Task<ApiResponse<List<IncomeStatementResponse>>> GetIncomeStatementAsync(
152161

153162
var queryString = new QueryStringBuilder();
154163

155-
queryString.Add("limit", limit);
164+
if (limit != null)
165+
{
166+
queryString.Add("limit", limit);
167+
}
156168

157169
if (period == Period.Quarter)
158170
{
@@ -162,7 +174,7 @@ public Task<ApiResponse<List<IncomeStatementResponse>>> GetIncomeStatementAsync(
162174
return client.GetAsync<List<IncomeStatementResponse>>(url, pathParams, queryString);
163175
}
164176

165-
public Task<ApiResponse<List<StockNewsResponse>>> GetStockNewsAsync(string symbol, int limit = 50)
177+
public Task<ApiResponse<List<StockNewsResponse>>> GetStockNewsAsync(string symbol, int? limit = 50)
166178
{
167179
const string url = "[version]/stock_news";
168180

@@ -174,7 +186,10 @@ public Task<ApiResponse<List<StockNewsResponse>>> GetStockNewsAsync(string symbo
174186
var queryString = new QueryStringBuilder();
175187

176188
queryString.Add("tickers", symbol);
177-
queryString.Add("limit", limit);
189+
if (limit != null)
190+
{
191+
queryString.Add("limit", limit);
192+
}
178193

179194
return client.GetAsync<List<StockNewsResponse>>(url, pathParams, queryString);
180195
}
@@ -199,7 +214,7 @@ public async Task<ApiResponse<CompanyRatingResponse>> GetCompanyRatingAsync(stri
199214
return ApiResponse.FromSucces(result.Data.First());
200215
}
201216

202-
public Task<ApiResponse<List<CompanyRatingResponse>>> GetHistoricalCompanyRatingAsync(string symbol, int limit = 140)
217+
public Task<ApiResponse<List<CompanyRatingResponse>>> GetHistoricalCompanyRatingAsync(string symbol, int? limit = 140)
203218
{
204219
const string url = "[version]/historical-rating/[symbol]";
205220

@@ -211,7 +226,10 @@ public Task<ApiResponse<List<CompanyRatingResponse>>> GetHistoricalCompanyRating
211226

212227
var queryString = new QueryStringBuilder();
213228

214-
queryString.Add("limit", limit);
229+
if (limit != null)
230+
{
231+
queryString.Add("limit", limit);
232+
}
215233

216234
return client.GetAsync<List<CompanyRatingResponse>>(url, pathParams, queryString);
217235
}
@@ -256,7 +274,7 @@ public Task<ApiResponse<List<HistoricalDCFResponse>>> GetHistoricalDiscountedCas
256274
return client.GetAsync<List<HistoricalDCFResponse>>(url, pathParams, queryString);
257275
}
258276

259-
public Task<ApiResponse<List<HistoricalDailyDCFResponse>>> GetHistoricalDiscountedCashFlowDailyAsync(string symbol, int limit = 100)
277+
public Task<ApiResponse<List<HistoricalDailyDCFResponse>>> GetHistoricalDiscountedCashFlowDailyAsync(string symbol, int? limit = 100)
260278
{
261279
const string url = "[version]/historical-discounted-cash-flow-statement/[symbol]";
262280

@@ -268,7 +286,10 @@ public Task<ApiResponse<List<HistoricalDailyDCFResponse>>> GetHistoricalDiscount
268286

269287
var queryString = new QueryStringBuilder();
270288

271-
queryString.Add("limit", limit);
289+
if (limit != null)
290+
{
291+
queryString.Add("limit", limit);
292+
}
272293

273294
return client.GetAsync<List<HistoricalDailyDCFResponse>>(url, pathParams, queryString);
274295
}
@@ -293,7 +314,7 @@ public async Task<ApiResponse<KeyMetricsTTMResponse>> GetCompanyKeyMetricsTTMAsy
293314
return ApiResponse.FromSucces(result.Data.First());
294315
}
295316

296-
public Task<ApiResponse<List<KeyMetricsResponse>>> GetCompanyKeyMetricsAsync(string symbol, Period period = Period.Annual, int limit = 130)
317+
public Task<ApiResponse<List<KeyMetricsResponse>>> GetCompanyKeyMetricsAsync(string symbol, Period period = Period.Annual, int? limit = 130)
297318
{
298319
const string url = "[version]/key-metrics/[symbol]";
299320

@@ -305,7 +326,10 @@ public Task<ApiResponse<List<KeyMetricsResponse>>> GetCompanyKeyMetricsAsync(str
305326

306327
var queryString = new QueryStringBuilder();
307328

308-
queryString.Add("limit", limit);
329+
if (limit != null)
330+
{
331+
queryString.Add("limit", limit);
332+
}
309333

310334
if (period != Period.Annual)
311335
{
@@ -355,7 +379,7 @@ public async Task<ApiResponse<MarketCapResponse>> GetMarketCapitalizationAsync(s
355379
return ApiResponse.FromSucces(result.Data.First());
356380
}
357381

358-
public Task<ApiResponse<List<MarketCapResponse>>> GetHistoricalMarketCapitalizationAsync(string symbol, int limit = 100)
382+
public Task<ApiResponse<List<MarketCapResponse>>> GetHistoricalMarketCapitalizationAsync(string symbol, int? limit = 100)
359383
{
360384
const string url = "[version]/historical-market-capitalization/[symbol]";
361385

@@ -366,7 +390,10 @@ public Task<ApiResponse<List<MarketCapResponse>>> GetHistoricalMarketCapitalizat
366390
};
367391

368392
var queryString = new QueryStringBuilder();
369-
queryString.Add("limit", limit);
393+
if (limit != null)
394+
{
395+
queryString.Add("limit", limit);
396+
}
370397

371398
return client.GetAsync<List<MarketCapResponse>>(url, pathParams, queryString);
372399
}

0 commit comments

Comments
 (0)