Return early in case of error to avoid NRE

Matthiee · Matthiee · commit 3fd694dd9df9 · 2021-05-18T18:37:16.000+02:00
diff --git a/FinancialModelingPrepApi/Core/Http/FinancialModelingPrepHttpClient.cs b/FinancialModelingPrepApi/Core/Http/FinancialModelingPrepHttpClient.cs
@@ -35,7 +35,7 @@ public async Task<ApiResponse<T>> GetAsync<T>(string urlPattern, NameValueCollec
 
                 if (response.HasError)
                 {
-                    ApiResponse.FromError<T>(response.Data);
+                    return ApiResponse.FromError<T>(response.Error);
                 }
 
                 if (response.Data.Contains("Error Message"))

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public async Task<ApiResponse<T>> GetAsync<T>(string urlPattern, NameValueCollec`
`35`	`35`
`36`	`36`	`if (response.HasError)`
`37`	`37`	`{`
`38`		`- ApiResponse.FromError<T>(response.Data);`
	`38`	`+ return ApiResponse.FromError<T>(response.Error);`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`if (response.Data.Contains("Error Message"))`