Skip to content

Commit ffe4dc8

Browse files
committed
Add more concurrency where possible
1 parent 6362681 commit ffe4dc8

File tree

4 files changed

+133
-16
lines changed

4 files changed

+133
-16
lines changed

.github/workflows/build-examples.yml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,6 @@ jobs:
3535
- name: 📦 Install dependencies
3636
run: yarn install --immutable
3737

38-
- name: 🏗️ Build library
39-
run: yarn build
40-
4138
- name: 🌐 Install Expo dependencies
4239
working-directory: example/expo
4340
run: yarn install --immutable
@@ -64,6 +61,9 @@ jobs:
6461
build-react-native:
6562
name: 📱 Build ${{ matrix.app }} (${{ matrix.platform }})
6663
runs-on: macos-15
64+
concurrency:
65+
group: build-react-native-${{ github.ref }}
66+
cancel-in-progress: true
6767
strategy:
6868
matrix:
6969
app: [fabric, paper]
@@ -83,9 +83,6 @@ jobs:
8383
- name: 📦 Install dependencies
8484
run: yarn install --immutable
8585

86-
- name: 🏗️ Build library
87-
run: yarn build
88-
8986
- name: 📱 Install dependencies for ${{ matrix.app }}
9087
working-directory: example/${{ matrix.app }}
9188
run: yarn install --immutable
@@ -117,7 +114,7 @@ jobs:
117114
working-directory: example/${{ matrix.app }}/ios
118115
run: |
119116
bundle install
120-
bundle exec pod update
117+
bundle exec pod install
121118
122119
- name: 🍎 Build iOS
123120
if: matrix.platform == 'ios'
@@ -161,9 +158,6 @@ jobs:
161158
- name: 📦 Install dependencies
162159
run: yarn install --immutable
163160

164-
- name: 🏗️ Build library
165-
run: yarn build
166-
167161
- name: 🌐 Install web dependencies
168162
working-directory: example/web
169163
run: yarn install --immutable

.github/workflows/code_quality_checks.yml

Lines changed: 61 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
- main
1010

1111
jobs:
12-
check:
12+
circular-deps:
1313
runs-on: ubuntu-latest
1414
steps:
1515
- name: 🛒 Checkout code
@@ -28,14 +28,74 @@ jobs:
2828
working-directory: packages/react-native-sortables
2929
run: yarn circular-dependency-check
3030

31+
typecheck:
32+
runs-on: ubuntu-latest
33+
steps:
34+
- name: 🛒 Checkout code
35+
uses: actions/checkout@v4
36+
37+
- name: 🔧 Setup Node.js
38+
uses: actions/setup-node@v4
39+
with:
40+
node-version: '20'
41+
cache: 'yarn'
42+
43+
- name: 📦 Install dependencies
44+
run: yarn install --immutable
45+
3146
- name: 🔎 Run typecheck
3247
run: yarn typecheck
3348

49+
lint:
50+
runs-on: ubuntu-latest
51+
steps:
52+
- name: 🛒 Checkout code
53+
uses: actions/checkout@v4
54+
55+
- name: 🔧 Setup Node.js
56+
uses: actions/setup-node@v4
57+
with:
58+
node-version: '20'
59+
cache: 'yarn'
60+
61+
- name: 📦 Install dependencies
62+
run: yarn install --immutable
63+
3464
- name: 🧹 Run lint
3565
run: yarn lint
3666

67+
format:
68+
runs-on: ubuntu-latest
69+
steps:
70+
- name: 🛒 Checkout code
71+
uses: actions/checkout@v4
72+
73+
- name: 🔧 Setup Node.js
74+
uses: actions/setup-node@v4
75+
with:
76+
node-version: '20'
77+
cache: 'yarn'
78+
79+
- name: 📦 Install dependencies
80+
run: yarn install --immutable
81+
3782
- name: 🎨 Run Prettier check
3883
run: yarn format:check
3984

85+
test:
86+
runs-on: ubuntu-latest
87+
steps:
88+
- name: 🛒 Checkout code
89+
uses: actions/checkout@v4
90+
91+
- name: 🔧 Setup Node.js
92+
uses: actions/setup-node@v4
93+
with:
94+
node-version: '20'
95+
cache: 'yarn'
96+
97+
- name: 📦 Install dependencies
98+
run: yarn install --immutable
99+
40100
- name: 🧪 Run tests
41101
run: yarn test

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"@types/eslint": "^9.6.1",
66
"@types/jest": "^29.5.12",
77
"@types/node": "^20.14.9",
8+
"concurrently": "^8.2.2",
89
"eslint": "^9.28.0",
910
"eslint-config-react-native-matipl01": "^3.2.0",
1011
"husky": "^9.1.4",
@@ -47,8 +48,8 @@
4748
"pod": "yarn workspaces foreach -A -p run pod",
4849
"postinstall": "yarn husky:install",
4950
"prepare": "husky",
50-
"test": "yarn lib test && yarn example:app test",
51-
"typecheck": "yarn lib typecheck && yarn example:app typecheck"
51+
"test": "concurrently 'yarn lib test' 'yarn example:app test'",
52+
"typecheck": "concurrently 'yarn lib typecheck' 'yarn example:app typecheck'"
5253
},
5354
"type": "module",
5455
"workspaces": {

yarn.lock

Lines changed: 65 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1896,6 +1896,13 @@ __metadata:
18961896
languageName: node
18971897
linkType: hard
18981898

1899+
"@babel/runtime@npm:^7.21.0":
1900+
version: 7.28.4
1901+
resolution: "@babel/runtime@npm:7.28.4"
1902+
checksum: 10c0/792ce7af9750fb9b93879cc9d1db175701c4689da890e6ced242ea0207c9da411ccf16dc04e689cc01158b28d7898c40d75598f4559109f761c12ce01e959bf7
1903+
languageName: node
1904+
linkType: hard
1905+
18991906
"@babel/template@npm:^7.25.0, @babel/template@npm:^7.25.9, @babel/template@npm:^7.26.9, @babel/template@npm:^7.3.3":
19001907
version: 7.26.9
19011908
resolution: "@babel/template@npm:7.26.9"
@@ -6991,6 +6998,26 @@ __metadata:
69916998
languageName: node
69926999
linkType: hard
69937000

7001+
"concurrently@npm:^8.2.2":
7002+
version: 8.2.2
7003+
resolution: "concurrently@npm:8.2.2"
7004+
dependencies:
7005+
chalk: "npm:^4.1.2"
7006+
date-fns: "npm:^2.30.0"
7007+
lodash: "npm:^4.17.21"
7008+
rxjs: "npm:^7.8.1"
7009+
shell-quote: "npm:^1.8.1"
7010+
spawn-command: "npm:0.0.2"
7011+
supports-color: "npm:^8.1.1"
7012+
tree-kill: "npm:^1.2.2"
7013+
yargs: "npm:^17.7.2"
7014+
bin:
7015+
conc: dist/bin/concurrently.js
7016+
concurrently: dist/bin/concurrently.js
7017+
checksum: 10c0/0e9683196fe9c071d944345d21d8f34aa6c0cc50c0dd897e95619f2f1c9eb4871dca851b2569da17888235b7335b4c821ca19deed35bebcd9a131ee5d247f34c
7018+
languageName: node
7019+
linkType: hard
7020+
69947021
"config-chain@npm:^1.1.11":
69957022
version: 1.1.13
69967023
resolution: "config-chain@npm:1.1.13"
@@ -7313,6 +7340,15 @@ __metadata:
73137340
languageName: node
73147341
linkType: hard
73157342

7343+
"date-fns@npm:^2.30.0":
7344+
version: 2.30.0
7345+
resolution: "date-fns@npm:2.30.0"
7346+
dependencies:
7347+
"@babel/runtime": "npm:^7.21.0"
7348+
checksum: 10c0/e4b521fbf22bc8c3db332bbfb7b094fd3e7627de0259a9d17c7551e2d2702608a7307a449206065916538e384f37b181565447ce2637ae09828427aed9cb5581
7349+
languageName: node
7350+
linkType: hard
7351+
73167352
"dayjs@npm:^1.8.15":
73177353
version: 1.11.13
73187354
resolution: "dayjs@npm:1.11.13"
@@ -14901,6 +14937,7 @@ __metadata:
1490114937
"@types/eslint": "npm:^9.6.1"
1490214938
"@types/jest": "npm:^29.5.12"
1490314939
"@types/node": "npm:^20.14.9"
14940+
concurrently: "npm:^8.2.2"
1490414941
eslint: "npm:^9.28.0"
1490514942
eslint-config-react-native-matipl01: "npm:^3.2.0"
1490614943
husky: "npm:^9.1.4"
@@ -15638,6 +15675,15 @@ __metadata:
1563815675
languageName: node
1563915676
linkType: hard
1564015677

15678+
"rxjs@npm:^7.8.1":
15679+
version: 7.8.2
15680+
resolution: "rxjs@npm:7.8.2"
15681+
dependencies:
15682+
tslib: "npm:^2.1.0"
15683+
checksum: 10c0/1fcd33d2066ada98ba8f21fcbbcaee9f0b271de1d38dc7f4e256bfbc6ffcdde68c8bfb69093de7eeb46f24b1fb820620bf0223706cff26b4ab99a7ff7b2e2c45
15684+
languageName: node
15685+
linkType: hard
15686+
1564115687
"safe-array-concat@npm:^1.1.3":
1564215688
version: 1.1.3
1564315689
resolution: "safe-array-concat@npm:1.1.3"
@@ -16268,6 +16314,13 @@ __metadata:
1626816314
languageName: node
1626916315
linkType: hard
1627016316

16317+
"spawn-command@npm:0.0.2":
16318+
version: 0.0.2
16319+
resolution: "spawn-command@npm:0.0.2"
16320+
checksum: 10c0/b22f2d71239e6e628a400831861ba747750bbb40c0a53323754cf7b84330b73d81e40ff1f9055e6d1971818679510208a9302e13d9ff3b32feb67e74d7a1b3ef
16321+
languageName: node
16322+
linkType: hard
16323+
1627116324
"spawn-error-forwarder@npm:~1.0.0":
1627216325
version: 1.0.0
1627316326
resolution: "spawn-error-forwarder@npm:1.0.0"
@@ -16779,7 +16832,7 @@ __metadata:
1677916832
languageName: node
1678016833
linkType: hard
1678116834

16782-
"supports-color@npm:^8.0.0":
16835+
"supports-color@npm:^8.0.0, supports-color@npm:^8.1.1":
1678316836
version: 8.1.1
1678416837
resolution: "supports-color@npm:8.1.1"
1678516838
dependencies:
@@ -17084,6 +17137,15 @@ __metadata:
1708417137
languageName: node
1708517138
linkType: hard
1708617139

17140+
"tree-kill@npm:^1.2.2":
17141+
version: 1.2.2
17142+
resolution: "tree-kill@npm:1.2.2"
17143+
bin:
17144+
tree-kill: cli.js
17145+
checksum: 10c0/7b1b7c7f17608a8f8d20a162e7957ac1ef6cd1636db1aba92f4e072dc31818c2ff0efac1e3d91064ede67ed5dc57c565420531a8134090a12ac10cf792ab14d2
17146+
languageName: node
17147+
linkType: hard
17148+
1708717149
"treeverse@npm:^3.0.0":
1708817150
version: 3.0.0
1708917151
resolution: "treeverse@npm:3.0.0"
@@ -17240,7 +17302,7 @@ __metadata:
1724017302
languageName: node
1724117303
linkType: hard
1724217304

17243-
"tslib@npm:2.8.1, tslib@npm:^2.4.0":
17305+
"tslib@npm:2.8.1, tslib@npm:^2.1.0, tslib@npm:^2.4.0":
1724417306
version: 2.8.1
1724517307
resolution: "tslib@npm:2.8.1"
1724617308
checksum: 10c0/9c4759110a19c53f992d9aae23aac5ced636e99887b51b9e61def52611732872ff7668757d4e4c61f19691e36f4da981cd9485e869b4a7408d689f6bf1f14e62
@@ -18297,7 +18359,7 @@ __metadata:
1829718359
languageName: node
1829818360
linkType: hard
1829918361

18300-
"yargs@npm:^17.3.1, yargs@npm:^17.5.1, yargs@npm:^17.6.2":
18362+
"yargs@npm:^17.3.1, yargs@npm:^17.5.1, yargs@npm:^17.6.2, yargs@npm:^17.7.2":
1830118363
version: 17.7.2
1830218364
resolution: "yargs@npm:17.7.2"
1830318365
dependencies:

0 commit comments

Comments
 (0)