Merge pull request #11 from Mathavana/develop

Develop - API Project structure changed

Author: MathavanN

README.md

@@ -2,8 +2,8 @@
 
 | Branch | CircleCi |
 | ------ | ------ |
-| master | ![CircleCI branch](https://img.shields.io/circleci/project/github/Mathavana/asp_net_core_api/master.svg?style=popout) |
-| develop | ![CircleCI branch](https://img.shields.io/circleci/project/github/Mathavana/asp_net_core_api/develop.svg?style=popout) |
+| master | [![CircleCI](https://circleci.com/gh/Mathavana/asp_net_core_api/tree/master.svg?style=svg)](https://circleci.com/gh/Mathavana/asp_net_core_api/tree/master) |
+| develop | [![CircleCI](https://circleci.com/gh/Mathavana/asp_net_core_api/tree/develop.svg?style=svg)](https://circleci.com/gh/Mathavana/asp_net_core_api/tree/develop) |
 
 We will try to create an API application using asp.net core.
 - Mainly using repository pattern, generics, LINQ, Entity framework core
@@ -16,13 +16,17 @@ We will try to create an API application using asp.net core.
 - Model.IsValid is removed in each controller. (ApiController auto implement Model.IsValid)
 - Models, Enums, Context, Repositories moved to Supermarket.Core project
 - xUnit Test Project added
+- CircleCi
+- Standard response for error (400,404) results (Similar to ApiController model validation result)
 
 ### Next ToDo List:
 - Role Based Authentication/Authorization
-- Standard response for both error/success results
 - Global Error Handling
 - Dockerization
-- CircleCi
+- More test cases needed
+- Proper model implementation
+- model to DB
+
 
 ### Note
 - Trying to understand best practices. May be frequently modified the project structure.

Supermarket.Core/Supermarket.Core.csproj

@@ -4,10 +4,6 @@
     <TargetFramework>netcoreapp2.2</TargetFramework>
   </PropertyGroup>
 
-  <ItemGroup>
-    <Folder Include="Services\Contracts\" />
-  </ItemGroup>
-
   <ItemGroup>
     <PackageReference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="2.2.0" />
     <PackageReference Include="Microsoft.EntityFrameworkCore" Version="2.2.3" />

Supermarket/ApiResponse/BadRequestResponse.cs

@@ -0,0 +1,17 @@
+using Microsoft.AspNetCore.Mvc;
+using System;
+using System.Collections.Generic;
+using System.Net;
+
+namespace Supermarket.ApiResponse
+{
+    public class BadRequestResponse : ValidationProblemDetails
+    {
+        public Guid TraceId { get; set; }
+        public BadRequestResponse(string error) : base(new Dictionary<string, string[]> { { "error", new[] { error } } })
+        {
+            TraceId = Guid.NewGuid();
+            Title = HttpStatusCode.BadRequest.ToString();
+        }
+    }
+}

Supermarket/ApiResponse/NotFoundResponse.cs

@@ -0,0 +1,17 @@
+using Microsoft.AspNetCore.Mvc;
+using System;
+using System.Collections.Generic;
+using System.Net;
+
+namespace Supermarket.ApiResponse
+{
+    public class NotFoundResponse : ValidationProblemDetails
+    {
+        public Guid TraceId { get; set; }
+        public NotFoundResponse(string error) : base(new Dictionary<string, string[]> { { "error", new[] { error } } })
+        {
+            TraceId = Guid.NewGuid();
+            Title = HttpStatusCode.NotFound.ToString();
+        }
+    }
+}