Merge pull request #213 from KnutZuidema/feat/nil_equal

feat: nil version equality

Author: mattfarina

version.go

@@ -390,6 +390,12 @@ func (v *Version) GreaterThan(o *Version) bool {
 // Note, versions can be equal with different metadata since metadata
 // is not considered part of the comparable version.
 func (v *Version) Equal(o *Version) bool {
+	if v == o {
+		return true
+	}
+	if v == nil || o == nil {
+		return false
+	}
 	return v.Compare(o) == 0
 }
 

version_test.go

@@ -343,28 +343,21 @@ func TestGreaterThan(t *testing.T) {
 
 func TestEqual(t *testing.T) {
 	tests := []struct {
-		v1       string
-		v2       string
+		v1       *Version
+		v2       *Version
 		expected bool
 	}{
-		{"1.2.3", "1.5.1", false},
-		{"2.2.3", "1.5.1", false},
-		{"3.2-beta", "3.2-beta", true},
-		{"3.2-beta+foo", "3.2-beta+bar", true},
+		{MustParse("1.2.3"), MustParse("1.5.1"), false},
+		{MustParse("2.2.3"), MustParse("1.5.1"), false},
+		{MustParse("3.2-beta"), MustParse("3.2-beta"), true},
+		{MustParse("3.2-beta+foo"), MustParse("3.2-beta+bar"), true},
+		{nil, nil, true},
+		{nil, MustParse("1.2.3"), false},
+		{MustParse("1.2.3"), nil, false},
 	}
 
 	for _, tc := range tests {
-		v1, err := NewVersion(tc.v1)
-		if err != nil {
-			t.Errorf("Error parsing version: %s", err)
-		}
-
-		v2, err := NewVersion(tc.v2)
-		if err != nil {
-			t.Errorf("Error parsing version: %s", err)
-		}
-
-		a := v1.Equal(v2)
+		a := tc.v1.Equal(tc.v2)
 		e := tc.expected
 		if a != e {
 			t.Errorf(