-
-
Notifications
You must be signed in to change notification settings - Fork 19.5k
Open
Description
Did you test the latest bugfix-2.1.x
code?
Yes, and the problem still exists.
Bug Description
Sending an M20
or M20 F
(with CUSTOM_FIRMWARE_UPLOAD
enabled) does not result in *.bin files being listed.
Bug Timeline
Most likely #23878
Expected behavior
*.bin files to be listed when appropriate from M20
and M20 F
Actual behavior
No *.bin files listed.
Steps to Reproduce
- Put a firmware *.bin file on an SD card.
- Put sdcard into printer
- Run
M20 F
- Observe bin file not listed
Version of Marlin Firmware
Bugfix-2.1.x 2022-06-11
Printer model
Ender 3 Pro
Electronics
v4.2.7 board, CR10_STOCKDISPLAY
Add-ons
No response
Bed Leveling
UBL Bilinear mesh
Your Slicer
Other (explain below)
Host Software
OctoPrint
Don't forget to include
- A ZIP file containing your
Configuration.h
andConfiguration_adv.h
.
Additional information & file uploads
Looking at cardreader.h, fileisBinary
and setBinFlag
are no-ops unless DO_LIST_BIN_FILES
is defined.
static bool fileIsBinary() { return TERN0(DO_LIST_BIN_FILES, flag.filenameIsBin); }
static void setBinFlag(const bool bin) { TERN(DO_LIST_BIN_FILES, flag.filenameIsBin = bin, UNUSED(bin)); }
DO_LIST_BIN_FILES
is defined in Conditionals_LCD.h:
#if ENABLED(DWIN_LCD_PROUI)
#define DO_LIST_BIN_FILES 1
#endif
So, fileIsBinary
always returns 0. 👎