[BUG] Compilation Issues as Conditionals not correctly calculated/processed - M993/M994

[DaLiV]

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

Preprocessor Marlin/src/inc/*
not running as expected depsite all variables defined where they are.
compiling with platformio on linux.

wanted to save-restore SPI flash between compilations M993/M994 - not compiled-in depsite all variables are defined

Expected behavior

executed
Conditionals-3-etc.h

#if ALL(SPI_FLASH, HAS_MEDIA, MARLIN_DEV_MODE)
  #define SPI_FLASH_BACKUP 1
#endif

Actual behavior

SPI_FLASH_BACKUP variable not set depsite explicit
SDSUPPORT and MARLIN_DEV_MODE in main configs
and
SPI_FLASH thru pins_MKS_ROBIN_NANO_V3_common.h

by checking which are set at #if ALL(SPI_FLASH, HAS_MEDIA, MARLIN_DEV_MODE)
only HAS_MEDIA is set ... other are not.

Steps to Reproduce

in Configuration.h define any board with SD
#define MOTHERBOARD BOARD_MKS_ROBIN_NANO_V3_1

and enable
#define SDSUPPORT

Also serial is requirement for board from preprocessors
#define SERIAL_PORT -1

in Configuration_adv.h
#define MARLIN_DEV_MODE

in Marlin/src/inc/Conditionals-3-etc.h add warning

 #if ALL(SPI_FLASH, HAS_MEDIA, MARLIN_DEV_MODE)
#warning "this line MUST BE PROCESSED"**
   #define SPI_FLASH_BACKUP 1
 #endif

pio run

warning not shown, also as xcommand not compiled-in.

Version of Marlin Firmware

latest git

Additional information & file uploads

similar problem previously noted in
#27807 (comment)

[ellensp]

/**
 * Conditionals-3-etc.h
 * Conditionals that need to be set before Configuration_adv.h or pins.h
 */

SPI_FLASH is set in pins
MARLIN_DEV_MODE is set in Configuration_adv.h

these two are not set before Conditionals-3-etc.h is called.

[DaLiV]

so - then fast way for exactly that:

diff --git a/Marlin/src/inc/Conditionals-3-etc.h b/Marlin/src/inc/Conditionals-3-etc.h
index 00bff0e..3fa8072 100644
--- a/Marlin/src/inc/Conditionals-3-etc.h
+++ b/Marlin/src/inc/Conditionals-3-etc.h
@@ -677,7 +677,3 @@
 #if ANY(PID_DEBUG, PID_BED_DEBUG, PID_CHAMBER_DEBUG)
   #define HAS_PID_DEBUG 1
 #endif
-
-#if ALL(SPI_FLASH, HAS_MEDIA, MARLIN_DEV_MODE)
-  #define SPI_FLASH_BACKUP 1
-#endif
diff --git a/Marlin/src/inc/Conditionals-4-adv.h b/Marlin/src/inc/Conditionals-4-adv.h
index a0eaa70..03a2144 100644
--- a/Marlin/src/inc/Conditionals-4-adv.h
+++ b/Marlin/src/inc/Conditionals-4-adv.h
@@ -1591,3 +1591,7 @@
   #undef AUTO_REPORT_SD_STATUS
   #define AUTO_REPORT_SD_STATUS
 #endif
+
+#if ALL(SPI_FLASH, HAS_MEDIA, MARLIN_DEV_MODE)
+  #define SPI_FLASH_BACKUP 1
+#endif

[ellensp]

yes, but no, Conditionals-4-adv.h is still before pins.h so SPI_FLASH is not yet set
use Conditionals-5-post.h

[DaLiV]

after compilation executed M993 and that lead to board reset (but on SD was created empty file)

echo:M993
echo:Now fresh file: spiflash.bin
>>> diveToFile  X0.0000 Y0.0000 Z0.0000
 path = 'spiflash.bin'
 startDirPtr = 0x2000CB48
 returning string spiflash.bin
<<< diveToFile  X0.0000 Y0.0000 Z0.0000
Writing to file: spiflash.bin
Save SPI Flash.....................................................start
echo:[1061] hal.init()
echo:[1061] tmc_serial_begin()
echo:[1061] hal.init_board()
 Watchdog Reset

[DaLiV]

SPI Flash 8MB /File created and written 16Mb = read doubled/ - quite big to run without watchdoig refreshing
as 55 points shown - so 55 x 10 x 1024 partially processed on "single run"
can suggest 32 /or 16/ as base for that opeartion.

diff --git a/Marlin/src/gcode/control/M993_M994.cpp b/Marlin/src/gcode/control/M993_M994.cpp
index bc634ae..fcb5727 100644
--- a/Marlin/src/gcode/control/M993_M994.cpp
+++ b/Marlin/src/gcode/control/M993_M994.cpp
@@ -50,6 +50,7 @@ void GcodeSuite::M993() {
     addr += COUNT(buf);
     card.write(buf, COUNT(buf));
     if (addr % (COUNT(buf) * 10) == 0) SERIAL_CHAR('.');
+    if (addr % (COUNT(buf) * 32) == 0) hal.watchdog_refresh();
   }
   SERIAL_ECHOLNPGM(" done");

• for restoring exist another lenghty operation ... here must be watchdog also "paused/stopped"
  void GcodeSuite::M994() {

W25QXX.SPI_FLASH_BulkErase();

[ellensp]

Pr created to fix this. Closing.