ExceptionHandlerHelper always respond with 500 code

[beeyev]

Hello, could you please help me.
I have implemented ExceptionHandlerHelper inside \App\Exceptions\Handler::render and it works well.
When I try to access a wrong route or manually abort execution using abort(404);
I receive a response which I was expected, example:

{
  "success": false,
  "code": 113,
  "locale": "en",
  "message": "Not Found",
  "data": null,
  "debug": {
    "trace": {
      "class": "Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException",
      "file": "\\/var\\/www\\/api\\/vendor\\/laravel\\/framework\\/src\\/Illuminate\\/Foundation\\/Application.php",
      "line": 1143
    }
  }
}

But the http code is always 500, how can I make it automatically set 404 code when it is needed? The Laravel itself does it correctly.

[MarcinOrlowski]

As it looks that the ex handler kicked in, it sounds a bit like incomplete configuration. Please post/attach your RB's config.

[beeyev]

I have checked this

/** @var \Symfony\Component\HttpKernel\Exception\HttpException $ex */
$http_code = $ex->getStatusCode();

And $ex->getStatusCode() indeed returns 404, but at the same time, the final output has 500 status code.
Here, I just opened a non-existent route:

I tried to implement your solution:

  \Symfony\Component\HttpKernel\Exception\HttpException::class => [
      'handler' => \MarcinOrlowski\ResponseBuilder\ExceptionHandlers\HttpExceptionHandler::class,
      'pri' => -100,
      'config' => [
          Symfony\Component\HttpFoundation\Response::HTTP_NOT_FOUND => [
              'http_code' => Symfony\Component\HttpFoundation\Response::HTTP_NOT_FOUND,
          ],

And after that, I receive this error whenever I try to access a wrong route:

{"success":false,"code":113,"locale":"en","message":"Undefined array key \u0022api_code\u0022","data":null,"debug":{"trace":{"class":"ErrorException","file":"\/var\/www\/api\/vendor\/marcin-orlowski\/laravel-api-response-builder\/src\/ExceptionHandlerHelper.php","line":104}}}

[MarcinOrlowski]

Ok, so one thing that undefined array key smells like a bug so I will fix separately, but for now, just try adding missing api_key entry to the config:

'api_code' => X

so it looks like

      'config' => [
          Symfony\Component\HttpFoundation\Response::HTTP_NOT_FOUND => [
              'http_code' => Symfony\Component\HttpFoundation\Response::HTTP_NOT_FOUND,
              'api_code' => X,
          ],

where X is any non-zero value that you want to be returned along with this exception. If you got no need for it set X to 404 for consistency. Let me know it helped in any way

[MarcinOrlowski]

FYI: "Undefined array key" you faced is now issue #226. No need to bother though.

• "Undefined array key" for ex handler config lacking i.e. api_code entry. #226

[beeyev]

Tried this solution, and it works!

\Symfony\Component\HttpKernel\Exception\HttpException::class => [
      'handler' => \MarcinOrlowski\ResponseBuilder\ExceptionHandlers\HttpExceptionHandler::class,
      'pri' => -100,
      'config' => [
          Symfony\Component\HttpFoundation\Response::HTTP_NOT_FOUND => [
              'http_code' => Symfony\Component\HttpFoundation\Response::HTTP_NOT_FOUND,
              'api_code' => 404,
          ],

Thank you! And thanks for the tool!

[MarcinOrlowski]

Great this helped. Please keep an eye on #226 so you will be able to remove this entry from your config once the bug is fixed. Enjoy the library :)

PS: please mark the answer as solution so I can freeze the thread.

[PitchRE]

@MarcinOrlowski I can confirm that this issue still persist. I did as comments in response_builder.php suggested =>

	HttpException::class => [
					// used by unauthenticated() to obtain api and http code for the exception
					HttpResponse::HTTP_UNAUTHORIZED         => [
						'api_code' => ApiCodes::UNAUTHORIZED,
							'http_code' => HttpResponse::HTTP_UNAUTHORIZED,
					],
				]

However, no matter what I do, HTTP response code is always 500.
AuthenticationException always throws 500.