Skip to content

Commit e0c2483

Browse files
authored
change start to continue after signer ready (#338)
* change start to continue after signer readty Signed-off-by: Apokalip <simeon@manta.network> * Changelog Signed-off-by: Apokalip <simeon@manta.network> --------- Signed-off-by: Apokalip <simeon@manta.network> Signed-off-by: Simeon Zahariev <43317481+Apokalip@users.noreply.github.com>
1 parent 54590f5 commit e0c2483

File tree

4 files changed

+20
-4
lines changed

4 files changed

+20
-4
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
88
### Added
99

1010
### Changed
11-
[\#332](https://github.com/Manta-Network/manta-signer/pull/332) Add sink account validation
11+
- [\#338](https://github.com/Manta-Network/manta-signer/pull/338) Change start button to continue in View zkAddress.
12+
- [\#332](https://github.com/Manta-Network/manta-signer/pull/332) Add sink account validation
1213

1314
### Deprecated
1415

ui/src/App.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ function App() {
3333
const [authorizationSummary, setAuthorizationSummary] = useState(null);
3434
const [receivingKey, setReceivingKey] = useState(null);
3535
const [loginSuccess, setLoginSuccess] = useState(false);
36+
const [signerReady, setSignerReady] = useState(false);
3637
const [receivingKeyDisplay, setReceivingKeyDisplay] = useState(null);
3738
const [activeListeners, setActiveListeners] = useState({
3839
authorize: false,
@@ -389,6 +390,8 @@ function App() {
389390
<SignIn
390391
loginSuccess={loginSuccess}
391392
setLoginSuccess={setLoginSuccess}
393+
signerReady={signerReady}
394+
setSignerReady={setSignerReady}
392395
sendSelection={sendSelection}
393396
getReceivingKeys={getReceivingKeys}
394397
receivingKey={receivingKey}

ui/src/pages/SignIn/SignIn.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import SignInSuccess from './SignInSuccess';
55
const SignIn = ({
66
loginSuccess,
77
setLoginSuccess,
8+
signerReady,
9+
setSignerReady,
810
sendSelection,
911
getReceivingKeys,
1012
receivingKey,
@@ -64,6 +66,7 @@ const SignIn = ({
6466
}
6567

6668
const onClickFinishSignIn = async () => {
69+
setSignerReady(true);
6770
await hideWindow();
6871
}
6972

@@ -80,6 +83,7 @@ const SignIn = ({
8083
}
8184
{loginSuccess &&
8285
<SignInSuccess
86+
signerReady={signerReady}
8387
receivingKeyDisplay={receivingKeyDisplay}
8488
showCopyNotification={showCopyNotification}
8589
onClickCopyZkAddress={onClickCopyZkAddress}

ui/src/pages/SignIn/SignInSuccess.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import CopyButton from '../../components/copyButton';
77
import "../../App.css";
88

99
const SignInSuccess = ({
10+
signerReady,
1011
receivingKeyDisplay,
1112
showCopyNotification,
1213
onClickCopyZkAddress,
@@ -56,9 +57,16 @@ const SignInSuccess = ({
5657
</div>
5758

5859
</div>
59-
<Button className="button ui first" onClick={onClickFinishSignIn}>
60-
Start
61-
</Button>
60+
{
61+
signerReady ?
62+
<Button className="button ui first" onClick={onClickFinishSignIn}>
63+
Continue
64+
</Button>
65+
:
66+
<Button className="button ui first" onClick={onClickFinishSignIn}>
67+
Start
68+
</Button>
69+
}
6270
</div>)
6371
}
6472

0 commit comments

Comments
 (0)