Skip to content

Commit 1a33e60

Browse files
committed
code review
1 parent cd6455c commit 1a33e60

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

release.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ The version numbers in the following files must be updated:
2828
2. ui/src-tauri/Cargo.toml
2929
3. ui/src-tauri/tauri.conf.json
3030
4. ui/public/about.html
31-
31+
5. ui/package.json
32+
3233
EOF
3334
prompt "Did you update the version numbers?"
3435

src/service.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,8 +369,9 @@ where
369369
/// Sends version to the client.
370370
#[inline]
371371
async fn version(request: Request<A>) -> ServerResult {
372-
Self::log(String::from("VERSION")).await?;
372+
Self::log(String::from("REQUEST: version")).await?;
373373
let _ = request;
374+
Self::log(format!("RESPONSE: {:?}", VERSION)).await?;
374375
Ok(Body::from_json(&VersionMessage::default())?.into())
375376
}
376377

ui/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "manta-signer-ui",
3-
"version": "0.4.0",
3+
"version": "0.5.0",
44
"private": true,
55
"dependencies": {
66
"@tauri-apps/api": "^1.0.0-beta.8",
@@ -43,4 +43,4 @@
4343
"devDependencies": {
4444
"@tauri-apps/cli": "^1.0.0-beta.10"
4545
}
46-
}
46+
}

ui/public/about.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ <h3>Manta Signer</h3>
4141
<p>Version 0.5.0</p>
4242
<p>Copyright © 2019-2021 Manta Network</p>
4343
<p>
44-
<a href="https://github.com/manta-network/manta-signer">manta-network/manta-signer</a
45-
>
46-
</p>
47-
<br />
48-
<p style="font-size: 0.75em; color: red">DOLPHIN TESTNET</p>
44+
<a href="https://github.com/manta-network/manta-signer">manta-network/manta-signer</a>
45+
</p>
46+
<br />
47+
<p style="font-size: 0.75em; color: red">DOLPHIN TESTNET</p>
4948
</main>
50-
</body>
49+
</body>
50+
5151
</html>

0 commit comments

Comments
 (0)