Skip to content

[BUG] Roll sound does not play for activity quick rolls (v12) #609

@lparkjordan

Description

@lparkjordan

Description
When using a quick roll for an attack or spell (possibly others as well, but that's all I've tested), no sound is played. I think it's fair to call this a bug because the quick roll performs several actions that would result in a die roll sound if they were performed via a vanilla chat message.

I think this could be fixed by adding a call to CoreUtility.playRollSound() in runActivityActions in activity.js - if it's helpful, I could put together a PR.

Steps to Reproduce

  1. Click on a weapon or spell in a character sheet and confirm any dialogues that appear.
  2. A quick roll with rolled attack and damage appears, but no die roll sound is played.

Versions

  • Module: [3.4.10]
  • dnd5e: [4.3.9]
  • Foundry: [12.331]

Other Modules
N/A

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions