Double rolls for DSN and animations for AA when chat is not open [BUG]

[Corvobyte]

Description
Double roll whenever rolling an attack while not in the chat menu, but when chat is open, it works normally.

Steps to Reproduce

1. Go to 'Any menu except chat'
2. Click on 'Any attack rolls'
3. See error

Versions

• Module: [3.5.0]
• dnd5e: [5.0.4]
• Foundry: [13.346]

Other Modules
I have DSN and Automated Animations, which shouldn't conflict, but they apply the part of rolling twice, such as adding another dice roll for attack and damage while putting a normal amount into the chat. As for animations, it uses an animation twice. It could also be a problem from Dice Tray, but I did not test.

[thennal10]

For anyone else struggling with this, it seems to be specifically an issue with the chat notifications. If you turn it to notification pip in the user interface configuration in core settings, it will only roll once.

[maragondi]

I have same problem :/

[Nolat]

Even with pip notification enabled, and only Ready Set Roll & Dice So Nice active, the bug still occurs.

[ekosino]

I'm seeing the bug as well between Dice So Nice and Ready Set Roll. If the chat box is opened the rolls animate correctly if it's closed the dice duplicate the animation but in chat they aren't duplicated. Switching to Pip notification from cards resolved it for me for now. Running same versions as the OP.

In addition if I disable Ready Set Roll then DSN animates correctly for rolls. So it does appear to be something with RSR not DSN causing the issue.

[DudeAndre]

I have this issue too, but only if the chat is not the select page in the open sidebar on the right. It usually is, so I don't mind too much, but it mess with BG3 Inspired HUD, so it would be great if this could be solved.

[DudeAndre]

I solved by change the user interface configuration, in Core, from "chat cards" to "notification pip"

[sperckest]

Findings and summary of above mentioned with Posable cause.

(Foundry dnd5e)

Specifically on Attack rolls 3D dice (Dice so Nice) are called twice and two sets of dice are rolled.
Also attack animation form (dnd5e animations) are called twice showing double animations.

A few variables that removes this double call are:

• Change RSR Setting "Roll Damage Manually" to something other than "Never"
• Closing Foundry SUB chat by having MAIN chat opened.
• Turn off SUB chat.

SUB chat was added to foundry vtt v13

Posable cause:

I note that the HOOKS_DND5E.RENDER_CHAT_MESSAGE is called twice when the SUB chat is open and not when closed.

When only the MAIN chat is opened it is called once, maybe the MAIN chat is never fully closed so it renders both the SUB chat and the MAIN chat triggering the call 2 times in raped susetion.

ready-set-roll-5e/src/utils/hooks.js
Line 157

static registerChatHooks() {
        LogUtility.log("Registering chat hooks");

        Hooks.on(HOOKS_DND5E.RENDER_CHAT_MESSAGE, (message, html,data) => {
            ChatUtility.processChatMessage(message, html);
        });
    }

Down stream of this hook is there is
ready-set-roll-5e/src/utils/chat.js
Line 31

ChatUtility.processChatMessage(message, html);

VERSION CHECK:
Bug demonstrated in
Foundery v13 346 and 347
Dnd 5e 5.0.4
ready-set-roll-5e 3.5.0

Foundery v12 worked as intended

Issue #607 #491 #606 might be related

Thanks for an Awesome Mod!

[dovrosenberg]

Seeing this issue whether or not chat tab is open, but setting to pip makes it only role once, Something tied to the rendering of the chat card like @sperckest suggests seems likely. Thanks for the great mod - would rather turn off the 3d dice than RSR!

[sperckest]

I found a temp fix:

ready-set-roll-5e/src/utils/chat.js
Line about 24 - 38
Replace:

/**
 * Utility class to handle binding chat cards for use by the module.
 */
export class ChatUtility {
    /**
     * Process a given chat message, adding module content and events to it.
     * Does nothing if the message is not the correct type.
     * @param {ChatMessage} message The chat message to process.
     * @param {JQuery} html The object data for the chat message.
     */
    static async processChatMessage(message, html) {
        if (!message || !html) {
            return;
        }

        if (!message.flags || Object.keys(message.flags).length === 0) {
            return;
        }

With:

 /**
 * Utility class to handle binding chat cards for use by the module.
 */
 export class ChatUtility {
    /**
     * Process a given chat message, adding module content and events to it.
     * Does nothing if the message is not the correct type.
     * @param {ChatMessage} message The chat message to process.
     * @param {JQuery} html The object data for the chat message.
     */
    constructor() {
    this.lastRenderCallMessage;
    this.firstRenderCall = true;
    }
   
    static async processChatMessage(message, html) {
        if (!message || !html) {
            return;
        }
        this.firstRenderCall = true;
        if (this.lastRenderCallMessage === message) {
            this.lastRenderCallMessage = message;
            this.firstRenderCall = false;
        }
        if (!message.flags || Object.keys(message.flags).length === 0) {
            return;
        }

ready-set-roll-5e/src/utils/chat.js
Line about 55
replace:

if (type == ROLL_TYPE.ACTIVITY && message.isAuthor)

With:

if (this.firstRenderCall && type == ROLL_TYPE.ACTIVITY && message.isAuthor)

This removes duplicate calls for the same render.

Foundery v13 347
Dnd 5e 5.1.2
ready-set-roll-5e 3.5.0

Can be optimized javascript is not my best langage.

[NoahOwcz]

How should I go about implementing these temporary changes if I don't host my Foundry on a server?

[NoahOwcz]

Is there an easier way then forking this repository? @sperckest