Merge pull request #65 from MaddyGuthridge/maddy-fix-item-parents

Resolve error where item parents were determined incorrectly

Author: MaddyGuthridge

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "minifolio",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "private": true,
   "license": "GPL-3.0-only",
   "scripts": {

package.json

@@ -47,7 +47,7 @@ export function itemIdFromStr(id: string): ItemId {
 
 /** Returns the ItemId for the parent of the given item */
 export function itemParent(itemId: ItemId): ItemId {
-  return itemIdFromComponents(itemComponents(itemId).slice(1));
+  return itemIdFromComponents(itemComponents(itemId).slice(0, -1));
 }
 
 /** Return an ItemId of a child of the given ItemId */

src/lib/itemId.ts

@@ -40,7 +40,7 @@ export async function POST(req: Request) {
 
   // Ensure parent exists
   const parent = await getItemInfo(itemId.parent(item))
-    .catch(() => error(404, `Parent of '${item}' does not exist`));
+    .catch(() => error(404, `Parent of '${item}' ('${itemId.parent(item)}') does not exist`));
   // Check if item exists
   if (await itemExists(item)) {
     error(400, `Item '${item}' already exists`);