Merge pull request #124 from MaddyGuthridge/maddy-sitemap-fixes

Fix issue with missing namespace for sitemap

Author: MaddyGuthridge

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "minifolio",
-  "version": "1.1.8",
+  "version": "1.1.9",
   "private": true,
   "license": "GPL-3.0-only",
   "scripts": {

package.json

@@ -52,7 +52,7 @@ export const gitClient = async (baseDir: string | undefined) => {
       '-o',
       `UserKnownHostsFile=${knownHostsFile()}`,
     ].join(' ');
-    console.log('Debug: gunning git with SSH command:');
+    console.log('Debug: running git with SSH command:');
     console.log(gitSshCommand);
     git = git.env('GIT_SSH_COMMAND', gitSshCommand);
   }

src/lib/server/git.ts

@@ -7,7 +7,10 @@ export async function GET(req: Request) {
 
   const baseUrl = `${req.url.protocol}//${req.url.host}`;
 
-  const root = create({ version: '1.0', encoding: 'UTF-8' }).ele('urlset');
+  const root = create({ version: '1.0', encoding: 'UTF-8' })
+    .ele('urlset')
+    .att('xmlns', 'http://www.sitemaps.org/schemas/sitemap/0.9');
+
   for await (const id of iterItems()) {
     root.ele('url').ele('loc').txt(`${baseUrl}${id}`);
   }

src/routes/sitemap.xml/+server.ts

@@ -19,6 +19,7 @@ beforeEach(async () => {
 it('Generates a basic sitemap for an empty site', async () => {
   await expect(api.sitemap()).resolves.toStrictEqual({
     urlset: {
+      '@xmlns': 'http://www.sitemaps.org/schemas/sitemap/0.9',
       url: {
         loc: `${BASE_URL}/`
       }
@@ -30,6 +31,7 @@ it('Includes children in sitemap', async () => {
   await api.item(itemId.fromStr('/child')).info.post('Child item');
   await expect(api.sitemap()).resolves.toStrictEqual({
     urlset: {
+      '@xmlns': 'http://www.sitemaps.org/schemas/sitemap/0.9',
       url: [
         {
           loc: `${BASE_URL}/`,