You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CHANGELOG.md
+14Lines changed: 14 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -4,6 +4,20 @@ All notable changes to this project will be documented in this file.
4
4
5
5
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
6
6
7
+
## [0.8.0] - July, 2024
8
+
9
+
### Features
10
+
11
+
* Add a new parameter `config_dict` in the `RulesEngine`'s constructor. It can be used when you have already loaded the YAML configuration in a dictionary and want to use it straightforward.
12
+
* Split a rule set in two (or more) files (keep the rules organized by their file names [alphabetically sorted]).
13
+
14
+
### Fixes
15
+
16
+
**Simple condition:* an error occurs when the right operand is a uppercase string (e.g., `input.text=="LABEL"`).
17
+
18
+
### Refactoring
19
+
20
+
* Function `sanitize_regex()` is converted to an instance method `get_sanitized_id()` of `BaseCondition` class.
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -11,7 +11,7 @@ Explain the layout of your repo.
11
11
12
12
## Workflow
13
13
14
-
The steps below describe how to get a patch into a main development branch (e.g. `master`).
14
+
The steps below describe how to get a patch into a main development branch (e.g. `master`).
15
15
The steps are exactly the same for everyone involved in the project (be it core team, or first time contributor).
16
16
We follow the standard GitHub [fork & pull](https://help.github.com/articles/using-pull-requests/#fork--pull) approach to pull requests. Just fork the official repo, develop in a branch, and submit a PR!
17
17
@@ -20,22 +20,22 @@ We follow the standard GitHub [fork & pull](https://help.github.com/articles/usi
20
20
1.[Fork the project](https://github.com/MAIF/arta#fork-destination-box) on GitHub. You'll need to create a feature-branch for your work on your fork, as this way you'll be able to submit a pull request against the mainline *Arta*.
21
21
1. Create a branch on your fork and work on the feature. For example: `git checkout -b feature/awesome-new-feature`
22
22
- Please make sure to follow the general quality guidelines (specified below) when developing your patch.
23
-
- Please write additional tests covering your feature and adjust existing ones if needed before submitting your pull request.
23
+
- Please write additional tests covering your feature and adjust existing ones if needed before submitting your pull request.
24
24
1. Once your feature is complete, prepare the commit with a good commit message, for example: `Adding canary mode support for services #42` (note the reference to the ticket it aimed to resolve).
25
25
1. If it's a new feature, or a change of behaviour, document it on the [Arta docs](https://maif.github.io/arta/home/), remember, an undocumented feature is not a feature.
26
26
1. Now it's finally time to [submit the pull request](https://help.github.com/articles/using-pull-requests)!
27
27
- Please make sure to include a reference to the issue you're solving *in the comment* for the Pull Request, this will cause the PR to be linked properly with the Issue. Examples of good phrases for this are: "Resolves #1234" or "Refs #1234".
28
28
1. Now both committers and interested people will review your code. This process is to ensure the code we merge is of the best possible quality, and that no silly mistakes slip through. You're expected to follow-up these comments by adding new commits to the same branch. The commit messages of those commits can be more loose, for example: `Removed debugging using printline`, as they all will be squashed into one commit before merging into the main branch.
29
29
- The community and team are eager to share, so don't be afraid to ask follow up questions if you didn't understand some comment, or would like clarification on how to continue with a given feature. We're here to help, so feel free to ask and discuss any kind of questions you might have during review!
30
-
1. After the review you should fix the issues as needed (pushing a new commit for new review etc.), iterating until the reviewers give their thumbs up–which is signalled usually by a comment saying `LGTM`, which means "Looks Good To Me".
30
+
1. After the review you should fix the issues as needed (pushing a new commit for new review etc.), iterating until the reviewers give their thumbs up–which is signalled usually by a comment saying `LGTM`, which means "Looks Good To Me".
31
31
1. If the code change needs to be applied to other branches as well (for example a bugfix needing to be backported to a previous version), one of the team will either ask you to submit a PR with the same commit to the old branch, or do this for you.
32
32
1. Once everything is said and done, your pull request gets merged. You've made it!
33
33
34
34
The TL;DR; of the above very precise workflow version is:
35
35
36
36
1. Fork arta
37
37
2. Hack and test on your feature (on a branch)
38
-
3. Document it
38
+
3. Document it
39
39
4. Submit a PR
40
40
6. Keep polishing it until received thumbs up from the core team
@@ -34,7 +35,7 @@ In other words, facilitate rules handling in our python apps.
34
35
35
36
The need of a python *rules engine* emerged when we were working on a new major release of our internal use of [Melusine](https://github.com/maif/melusine) (i.e., email qualification pipeline with ML capabilities).
36
37
37
-
We were looking for a python library to *centralize, manage and standardize* all the implemented **business rules** we had but didn't find the perfect fit.
38
+
We were looking for a python library to *centralize, manage and standardize* all the implemented **business rules** we had but didn't find the perfect fit.
38
39
39
40
Therefore, we decided to create this package and by extension of the MAIF's values, we planned to share it to the community.
40
41
@@ -139,4 +140,3 @@ and general hints on how to prepare your pull request. You can also ask for clar
139
140
This project is Open Source and available under the Apache 2 License.
0 commit comments