Put missed meals notifications behind feature flag

Author: ps2

Common/FeatureFlags.swift

@@ -38,6 +38,7 @@ struct FeatureFlagConfiguration: Decodable {
     let dynamicCarbAbsorptionEnabled: Bool
     let adultChildInsulinModelSelectionEnabled: Bool
     let profileExpirationSettingsViewEnabled: Bool
+    let missedMealNotifications: Bool
 
 
     fileprivate init() {
@@ -220,6 +221,14 @@ struct FeatureFlagConfiguration: Decodable {
         #else
         self.profileExpirationSettingsViewEnabled = true
         #endif
+
+        // Missed meal notifications compiler flag is inverse, since the default state is enabled.
+        #if MISSED_MEAL_NOTIFICATIONS_DISABLED
+        self.missedMealNotifications = false
+        #else
+        self.missedMealNotifications = true
+        #endif
+
     }
 }
 
@@ -253,7 +262,8 @@ extension FeatureFlagConfiguration : CustomDebugStringConvertible {
             "* usePositiveMomentumAndRCForManualBoluses: \(usePositiveMomentumAndRCForManualBoluses)",
             "* dynamicCarbAbsorptionEnabled: \(dynamicCarbAbsorptionEnabled)",
             "* adultChildInsulinModelSelectionEnabled: \(adultChildInsulinModelSelectionEnabled)",
-            "* profileExpirationSettingsViewEnabled: \(profileExpirationSettingsViewEnabled)"
+            "* profileExpirationSettingsViewEnabled: \(profileExpirationSettingsViewEnabled)",
+            "* missedMealNotifications: \(missedMealNotifications)"
         ].joined(separator: "\n")
     }
 }

Loop/Managers/LoopDataManager.swift

@@ -874,26 +874,28 @@ extension LoopDataManager {
         logger.default("Loop ended")
         notify(forChange: .loopFinished)
 
-        let carbEffectStart = now().addingTimeInterval(-MissedMealSettings.maxRecency)
-        carbStore.getGlucoseEffects(start: carbEffectStart, end: now(), effectVelocities: insulinCounteractionEffects) {[weak self] result in
-            guard
-                let self = self,
-                case .success((_, let carbEffects)) = result
-            else {
-                if case .failure(let error) = result {
-                    self?.logger.error("Failed to fetch glucose effects to check for missed meal: %{public}@", String(describing: error))
+        if FeatureFlags.missedMealNotifications {
+            let carbEffectStart = now().addingTimeInterval(-MissedMealSettings.maxRecency)
+            carbStore.getGlucoseEffects(start: carbEffectStart, end: now(), effectVelocities: insulinCounteractionEffects) {[weak self] result in
+                guard
+                    let self = self,
+                    case .success((_, let carbEffects)) = result
+                else {
+                    if case .failure(let error) = result {
+                        self?.logger.error("Failed to fetch glucose effects to check for missed meal: %{public}@", String(describing: error))
+                    }
+                    return
                 }
-                return
+                
+                self.mealDetectionManager.generateMissedMealNotificationIfNeeded(
+                    insulinCounteractionEffects: self.insulinCounteractionEffects,
+                    carbEffects: carbEffects,
+                    pendingAutobolusUnits: self.recommendedAutomaticDose?.recommendation.bolusUnits,
+                    bolusDurationEstimator: { [unowned self] bolusAmount in
+                        return self.delegate?.loopDataManager(self, estimateBolusDuration: bolusAmount)
+                    }
+                )
             }
-            
-            self.mealDetectionManager.generateMissedMealNotificationIfNeeded(
-                insulinCounteractionEffects: self.insulinCounteractionEffects,
-                carbEffects: carbEffects,
-                pendingAutobolusUnits: self.recommendedAutomaticDose?.recommendation.bolusUnits,
-                bolusDurationEstimator: { [unowned self] bolusAmount in
-                    return self.delegate?.loopDataManager(self, estimateBolusDuration: bolusAmount)
-                }
-            )
         }
 
         // 5 second delay to allow stores to cache data before it is read by widget

Loop/Views/AlertManagementView.swift

@@ -66,7 +66,9 @@ struct AlertManagementView: View {
             if FeatureFlags.criticalAlertsEnabled {
                 muteAlertsSection
             }
-            missedMealAlertSection
+            if FeatureFlags.missedMealNotifications {
+                missedMealAlertSection
+            }
         }
         .navigationTitle(NSLocalizedString("Alert Management", comment: "Title of alert management screen"))
     }