Merge pull request #568 from tidepool-org/cameron/COASTAL-1246-reset-loop-cleanup

Author: Camji55

Loop/AppDelegate.swift

@@ -46,7 +46,7 @@ final class AppDelegate: UIResponder, UIApplicationDelegate, WindowProvider {
     func applicationWillEnterForeground(_ application: UIApplication) {
         log.default(#function)
 
-        loopAppManager.askUserToConfirmCrashIfNecessary()
+        loopAppManager.askUserToConfirmLoopReset()
     }
 
     func applicationWillTerminate(_ application: UIApplication) {

Loop/Managers/Alerts/AlertManager.swift

@@ -784,14 +784,16 @@ extension AlertManager: AlertPermissionsCheckerDelegate {
 }
 
 extension AlertManager {
-    func presentConfirmCrashAlert(confirmAction: @escaping (@escaping () -> Void) -> Void) {
-        let alert = UIAlertController(title: "New Study Product Detected", message: "We've detected a new study product is selected. In order to show use this study product, Tidepool Loop will need to restart.", preferredStyle: .alert)
+    func presentLoopResetConfirmationAlert(confirmAction: @escaping (@escaping () -> Void) -> Void, cancelAction: @escaping () -> Void) {
+        let alert = UIAlertController(title: "Loop Reset Requested", message: "We've detected a Loop reset may be needed. Tapping confirm will reset Loop and quit the app.", preferredStyle: .alert)
         alert.addAction(UIAlertAction(title: "Confirm", style: .default, handler: { _ in
             confirmAction() {
                 fatalError("DEBUG: Resetting Loop")
             }
         }))
-        alert.addAction(UIAlertAction(title: "Cancel", style: .cancel))
+        alert.addAction(UIAlertAction(title: "Cancel", style: .cancel, handler: { _ in
+            cancelAction()
+        }))
 
         alertPresenter.present(alert, animated: true)
     }

Loop/Managers/LoopAppManager.swift

@@ -290,7 +290,7 @@ class LoopAppManager: NSObject {
 
         alertManager.playbackAlertsFromPersistence()
 
-        askUserToConfirmCrashIfNecessary()
+        askUserToConfirmLoopReset()
     }
 
     // MARK: - Life Cycle
@@ -400,27 +400,68 @@ class LoopAppManager: NSObject {
         return false
     }
 
-    func askUserToConfirmCrashIfNecessary() {
-        deviceDataManager.pluginManager.availableSupports.forEach { supportUI in
-            if supportUI.loopNeedsReset {
-                alertManager.presentConfirmCrashAlert() { [weak self] completion in
+    func askUserToConfirmLoopReset() {
+        if UserDefaults.appGroup?.userRequestedLoopReset == true {
+            alertManager.presentLoopResetConfirmationAlert(
+                confirmAction: { [weak self] completion in
                     guard let pumpManager = self?.deviceDataManager.pumpManager else {
-                        supportUI.resetLoop()
+                        self?.resetLoop()
                         completion()
                         return
                     }
 
                     pumpManager.prepareForDeactivation() { [weak self] error in
                         guard let error = error else {
-                            supportUI.resetLoop()
+                            self?.resetLoop()
                             completion()
                             return
                         }
                         self?.alertManager.presentCouldNotResetLoopAlert(error: error)
                     }
+                },
+                cancelAction: {
+                    UserDefaults.appGroup?.userRequestedLoopReset = false
                 }
+            )
+        }
+    }
+    
+    private func resetLoop() {
+        deviceDataManager.pluginManager.availableSupports.enumerated().forEach { index, supportUI in
+            supportUI.loopWillReset()
+            
+            if index == deviceDataManager.pluginManager.availableSupports.count - 1 {
+                resetLoopDocuments()
+                resetLoopUserDefaults()
             }
+            
+            supportUI.loopDidReset()
+        }
+    }
+    
+    private func resetLoopUserDefaults() {
+        // Store values to persist
+        let allowDebugFeatures = UserDefaults.appGroup?.allowDebugFeatures
+
+        // Wipe away whole domain
+        UserDefaults.appGroup?.removePersistentDomain(forName: Bundle.main.appGroupSuiteName)
+
+        // Restore values to persist
+        UserDefaults.appGroup?.allowDebugFeatures = allowDebugFeatures ?? false
+    }
+    
+    private func resetLoopDocuments() {
+        guard let directoryURL = FileManager.default.containerURL(forSecurityApplicationGroupIdentifier: Bundle.main.appGroupSuiteName) else {
+            preconditionFailure("Could not get a container directory URL. Please ensure App Groups are set up correctly in entitlements.")
+        }
+        
+        let documents: URL = directoryURL.appendingPathComponent("com.loopkit.LoopKit", isDirectory: true)
+        try? FileManager.default.removeItem(at: documents)
+        
+        guard let localDocuments = try? FileManager.default.url(for: .documentDirectory, in: .userDomainMask, appropriateFor: nil, create: true) else {
+            preconditionFailure("Could not get a documents directory URL.")
         }
+        try? FileManager.default.removeItem(at: localDocuments)
     }
 
     private var rootViewController: UIViewController? {

LoopCore/NSUserDefaults.swift

@@ -21,6 +21,7 @@ extension UserDefaults {
         case allowDebugFeatures = "com.loopkit.Loop.allowDebugFeatures"
         case allowSimulators = "com.loopkit.Loop.allowSimulators"
         case LastMissedMealNotification = "com.loopkit.Loop.lastMissedMealNotification"
+        case userRequestedLoopReset = "com.loopkit.Loop.userRequestedLoopReset"
     }
 
     public static let appGroup = UserDefaults(suiteName: Bundle.main.appGroupSuiteName)
@@ -150,6 +151,15 @@ extension UserDefaults {
     public var allowSimulators: Bool {
         return bool(forKey: Key.allowSimulators.rawValue)
     }
+    
+    public var userRequestedLoopReset: Bool {
+        get {
+            bool(forKey: Key.userRequestedLoopReset.rawValue)
+        }
+        set {
+            setValue(newValue, forKey: Key.userRequestedLoopReset.rawValue)
+        }
+    }
 
     public func removeLegacyLoopSettings() {
         removeObject(forKey: "com.loudnate.Naterade.BasalRateSchedule")

LoopTests/Managers/SupportManagerTests.swift

@@ -40,10 +40,9 @@ class SupportManagerTests: XCTestCase {
         required init?(rawState: RawStateValue) { super.init() }
         var rawState: RawStateValue = [:]
 
-        var loopNeedsReset: Bool = false
-        var studyProductSelection: String? = nil
         func getScenarios(from scenarioURLs: [URL]) -> [LoopScenario] { [] }
-        func resetLoop() {}
+        func loopWillReset() {}
+        func loopDidReset() {}
     }
     class AnotherMockSupport: Mixin, SupportUI {
         func configurationMenuItems() -> [AnyView] { return [] }
@@ -52,10 +51,9 @@ class SupportManagerTests: XCTestCase {
         required init?(rawState: RawStateValue) { super.init() }
         var rawState: RawStateValue = [:]
 
-        var loopNeedsReset: Bool = false
-        var studyProductSelection: String? = nil
         func getScenarios(from scenarioURLs: [URL]) -> [LoopScenario] { [] }
-        func resetLoop() {}
+        func loopWillReset() {}
+        func loopDidReset() {}
     }
 
     class MockAlertIssuer: AlertIssuer {