[LOOP-3384] correct when and how the accessibility string updates with status highlights (#547)

Author: nhamming

LoopUI/ViewModel/CGMStatusHUDViewModel.swift

@@ -60,10 +60,12 @@ public class CGMStatusHUDViewModel {
             if isManualGlucoseCurrent {
                 // If there is a current manual glucose, it displays the current status highlight icon
                 setManualGlucoseTrendIconOverride()
-            } else if let localizedMessage = storedStatusHighlight?.localizedMessage,
-                      let statusState = storedStatusHighlight?.state
+            }
+
+            if let localizedMessage = storedStatusHighlight?.localizedMessage.replacingOccurrences(of: "\n", with: " "),
+               let statusStateMessage = storedStatusHighlight?.state.localizedDescription
             {
-                accessibilityString = localizedMessage + ", " + statusState.localizedDescription
+                accessibilityString = localizedMessage + ", " + statusStateMessage
             }
         }
     }
@@ -156,16 +158,19 @@ public class CGMStatusHUDViewModel {
         if isManualGlucoseCurrent {
             // a manual glucose value presents any status highlight icon instead of a trend icon
             setManualGlucoseTrendIconOverride()
-            if let statusState = storedStatusHighlight?.state {
-                accessibilityStrings.append(statusState.localizedDescription)
-            }
         } else if let trend = glucoseDisplay?.trendType, glucoseValueCurrent {
             self.trend = trend
             glucoseTrendTintColor = glucoseDisplay?.glucoseRangeCategory?.trendColor ?? .glucoseTintColor
             accessibilityStrings.append(trend.localizedDescription)
         } else {
             glucoseTrendTintColor = .glucoseTintColor
         }
+
+        if let statusStateMessage = storedStatusHighlight?.state.localizedDescription,
+           let localizedMessage = storedStatusHighlight?.localizedMessage.replacingOccurrences(of: "\n", with: " ")
+        {
+            accessibilityStrings.append(localizedMessage + ", " + statusStateMessage)
+        }
 
         unitsString = unit.localizedShortUnitString
         accessibilityString = accessibilityStrings.joined(separator: ", ")

LoopUI/Views/CGMStatusHUDView.swift

@@ -68,6 +68,8 @@ public final class CGMStatusHUDView: DeviceStatusHUDView, NibLoadable {
         defer {
             // when the status highlight is updated, the trend icon may also need to be updated
             updateTrendIcon()
+            // when the status highlight is updated, the accessibility string is updated
+            accessibilityValue = viewModel.accessibilityString
         }
 
         guard statusStackView.arrangedSubviews.contains(glucoseValueHUD),
@@ -89,6 +91,8 @@ public final class CGMStatusHUDView: DeviceStatusHUDView, NibLoadable {
         defer {
             // when the status highlight is updated, the trend icon may also need to be updated
             updateTrendIcon()
+            // when the status highlight is updated, the accessibility string is updated
+            accessibilityValue = viewModel.accessibilityString
         }
 
         guard statusStackView.arrangedSubviews.contains(statusHighlightView) else {