Skip to content

Commit 4909f52

Browse files
authored
Remote 1: Action Models (#1930)
* Remote Action Models * Move RemoteAction validation to extensions in Loop target * Use Action verbiage rather than RemoteAction * update naming * Request background processing time for entire asynchronous execution
1 parent 51fa1f4 commit 4909f52

14 files changed

+1139
-414
lines changed

Loop.xcodeproj/project.pbxproj

Lines changed: 41 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,6 +367,12 @@
367367
A98556852493F901000FD662 /* AlertStore+SimulatedCoreData.swift in Sources */ = {isa = PBXBuildFile; fileRef = A98556842493F901000FD662 /* AlertStore+SimulatedCoreData.swift */; };
368368
A987CD4924A58A0100439ADC /* ZipArchive.swift in Sources */ = {isa = PBXBuildFile; fileRef = A987CD4824A58A0100439ADC /* ZipArchive.swift */; };
369369
A999D40624663D18004C89D4 /* PumpManagerError.swift in Sources */ = {isa = PBXBuildFile; fileRef = A999D40524663D18004C89D4 /* PumpManagerError.swift */; };
370+
A99A114229A581F4007919CE /* BolusAction.swift in Sources */ = {isa = PBXBuildFile; fileRef = A99A114129A581F4007919CE /* BolusAction.swift */; };
371+
A99A114429A5829A007919CE /* CarbAction.swift in Sources */ = {isa = PBXBuildFile; fileRef = A99A114329A5829A007919CE /* CarbAction.swift */; };
372+
A99A114629A582A2007919CE /* OverrideAction.swift in Sources */ = {isa = PBXBuildFile; fileRef = A99A114529A582A2007919CE /* OverrideAction.swift */; };
373+
A99A114E29A5879D007919CE /* BolusActionTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A99A114B29A5879C007919CE /* BolusActionTests.swift */; };
374+
A99A114F29A5879D007919CE /* CarbActionTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A99A114C29A5879C007919CE /* CarbActionTests.swift */; };
375+
A99A115029A5879D007919CE /* OverrideActionTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A99A114D29A5879C007919CE /* OverrideActionTests.swift */; };
370376
A9A056B324B93C62007CF06D /* CriticalEventLogExportView.swift in Sources */ = {isa = PBXBuildFile; fileRef = A9A056B224B93C62007CF06D /* CriticalEventLogExportView.swift */; };
371377
A9A056B524B94123007CF06D /* CriticalEventLogExportViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = A9A056B424B94123007CF06D /* CriticalEventLogExportViewModel.swift */; };
372378
A9A63F8E246B271600588D5B /* NSTimeInterval.swift in Sources */ = {isa = PBXBuildFile; fileRef = 439897341CD2F7DE00223065 /* NSTimeInterval.swift */; };
@@ -1349,6 +1355,12 @@
13491355
A98556842493F901000FD662 /* AlertStore+SimulatedCoreData.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "AlertStore+SimulatedCoreData.swift"; sourceTree = "<group>"; };
13501356
A987CD4824A58A0100439ADC /* ZipArchive.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ZipArchive.swift; sourceTree = "<group>"; };
13511357
A999D40524663D18004C89D4 /* PumpManagerError.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PumpManagerError.swift; sourceTree = "<group>"; };
1358+
A99A114129A581F4007919CE /* BolusAction.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BolusAction.swift; sourceTree = "<group>"; };
1359+
A99A114329A5829A007919CE /* CarbAction.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CarbAction.swift; sourceTree = "<group>"; };
1360+
A99A114529A582A2007919CE /* OverrideAction.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OverrideAction.swift; sourceTree = "<group>"; };
1361+
A99A114B29A5879C007919CE /* BolusActionTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = BolusActionTests.swift; sourceTree = "<group>"; };
1362+
A99A114C29A5879C007919CE /* CarbActionTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CarbActionTests.swift; sourceTree = "<group>"; };
1363+
A99A114D29A5879C007919CE /* OverrideActionTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = OverrideActionTests.swift; sourceTree = "<group>"; };
13521364
A9A056B224B93C62007CF06D /* CriticalEventLogExportView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CriticalEventLogExportView.swift; sourceTree = "<group>"; };
13531365
A9A056B424B94123007CF06D /* CriticalEventLogExportViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CriticalEventLogExportViewModel.swift; sourceTree = "<group>"; };
13541366
A9B607AF247F000F00792BE4 /* UserNotifications+Loop.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UserNotifications+Loop.swift"; sourceTree = "<group>"; };
@@ -1986,6 +1998,7 @@
19861998
43757D131C06F26C00910CB9 /* Models */ = {
19871999
isa = PBXGroup;
19882000
children = (
2001+
A99A114029A581D6007919CE /* Remote */,
19892002
43511CDD21FD80AD00566C63 /* RetrospectiveCorrection */,
19902003
A9FB75F0252BE320004C7D3F /* BolusDosingDecision.swift */,
19912004
C17824A41E1AD4D100D9D25C /* ManualBolusRecommendation.swift */,
@@ -2753,6 +2766,27 @@
27532766
path = Shortcuts;
27542767
sourceTree = "<group>";
27552768
};
2769+
A99A114029A581D6007919CE /* Remote */ = {
2770+
isa = PBXGroup;
2771+
children = (
2772+
A99A114129A581F4007919CE /* BolusAction.swift */,
2773+
A99A114329A5829A007919CE /* CarbAction.swift */,
2774+
A99A114529A582A2007919CE /* OverrideAction.swift */,
2775+
);
2776+
path = Remote;
2777+
sourceTree = "<group>";
2778+
};
2779+
A99A114A29A58789007919CE /* Remote */ = {
2780+
isa = PBXGroup;
2781+
children = (
2782+
A9E8A80428A7CAC000C0A8A4 /* RemoteCommandTests.swift */,
2783+
A99A114B29A5879C007919CE /* BolusActionTests.swift */,
2784+
A99A114C29A5879C007919CE /* CarbActionTests.swift */,
2785+
A99A114D29A5879C007919CE /* OverrideActionTests.swift */,
2786+
);
2787+
path = Remote;
2788+
sourceTree = "<group>";
2789+
};
27562790
A9E6DFE4246A0418005B1A1C /* Extensions */ = {
27572791
isa = PBXGroup;
27582792
children = (
@@ -2764,13 +2798,13 @@
27642798
A9E6DFED246A0460005B1A1C /* Models */ = {
27652799
isa = PBXGroup;
27662800
children = (
2801+
A99A114A29A58789007919CE /* Remote */,
27672802
A9DFAFB224F0415E00950D1E /* CarbBackfillRequestUserInfoTests.swift */,
27682803
A963B279252CEBAE0062AA12 /* SetBolusUserInfoTests.swift */,
27692804
A9DFAFB424F048A000950D1E /* WatchHistoricalCarbsTests.swift */,
27702805
C19008FF252271BB00721625 /* SimpleBolusCalculatorTests.swift */,
27712806
A9C1719625366F780053BCBD /* WatchHistoricalGlucoseTest.swift */,
27722807
A9BD28E6272226B40071DF15 /* TestLocalizedError.swift */,
2773-
A9E8A80428A7CAC000C0A8A4 /* RemoteCommandTests.swift */,
27742808
);
27752809
path = Models;
27762810
sourceTree = "<group>";
@@ -3757,6 +3791,7 @@
37573791
C17824A01E19CF9800D9D25C /* GlucoseThresholdTableViewController.swift in Sources */,
37583792
4372E487213C86240068E043 /* SampleValue.swift in Sources */,
37593793
437CEEE41CDE5C0A003C8C80 /* UIImage.swift in Sources */,
3794+
A99A114229A581F4007919CE /* BolusAction.swift in Sources */,
37603795
C1201E2C23ECDBD0002DA84A /* WatchContextRequestUserInfo.swift in Sources */,
37613796
1D49795824E7289700948F05 /* ServicesViewModel.swift in Sources */,
37623797
1D4A3E2D2478628500FD601B /* StoredAlert+CoreDataClass.swift in Sources */,
@@ -3816,6 +3851,7 @@
38163851
1D6B1B6726866D89009AC446 /* AlertPermissionsChecker.swift in Sources */,
38173852
4F08DE8F1E7BB871006741EA /* CollectionType+Loop.swift in Sources */,
38183853
A9F703772489D8AA00C98AD8 /* PersistentDeviceLog+SimulatedCoreData.swift in Sources */,
3854+
A99A114629A582A2007919CE /* OverrideAction.swift in Sources */,
38193855
E9B080B1253BDA6300BAD8F8 /* UserDefaults+LoopIntents.swift in Sources */,
38203856
C1AF062329426300002C1B19 /* ManualGlucoseEntryRow.swift in Sources */,
38213857
C148CEE724FD91BD00711B3B /* DeliveryUncertaintyAlertManager.swift in Sources */,
@@ -3864,6 +3900,7 @@
38643900
A9C62D842331700E00535612 /* DiagnosticLog+Subsystem.swift in Sources */,
38653901
895FE0952201234000FCF18A /* OverrideSelectionViewController.swift in Sources */,
38663902
C1EF747228D6A44A00C8C083 /* CrashRecoveryManager.swift in Sources */,
3903+
A99A114429A5829A007919CE /* CarbAction.swift in Sources */,
38673904
A9F66FC3247F451500096EA7 /* UIDevice+Loop.swift in Sources */,
38683905
439706E622D2E84900C81566 /* PredictionSettingTableViewCell.swift in Sources */,
38693906
430D85891F44037000AF2D4F /* HUDViewTableViewCell.swift in Sources */,
@@ -4034,10 +4071,12 @@
40344071
buildActionMask = 2147483647;
40354072
files = (
40364073
A9DF02CB24F72B9E00B7C988 /* CriticalEventLogTests.swift in Sources */,
4074+
A99A114F29A5879D007919CE /* CarbActionTests.swift in Sources */,
40374075
B44251B3252350CE00605937 /* ChartAxisValuesStaticGeneratorTests.swift in Sources */,
40384076
1D80313D24746274002810DF /* AlertStoreTests.swift in Sources */,
40394077
C1777A6625A125F100595963 /* ManualEntryDoseViewModelTests.swift in Sources */,
40404078
C16B984026B4898800256B05 /* DoseEnactorTests.swift in Sources */,
4079+
A99A115029A5879D007919CE /* OverrideActionTests.swift in Sources */,
40414080
A9A63F8E246B271600588D5B /* NSTimeInterval.swift in Sources */,
40424081
A9DFAFB324F0415E00950D1E /* CarbBackfillRequestUserInfoTests.swift in Sources */,
40434082
A963B27A252CEBAE0062AA12 /* SetBolusUserInfoTests.swift in Sources */,
@@ -4057,6 +4096,7 @@
40574096
B4CAD8792549D2540057946B /* LoopCompletionFreshnessTests.swift in Sources */,
40584097
1D8D55BC252274650044DBB6 /* BolusEntryViewModelTests.swift in Sources */,
40594098
A91E4C2124F867A700BE9213 /* StoredAlertTests.swift in Sources */,
4099+
A99A114E29A5879D007919CE /* BolusActionTests.swift in Sources */,
40604100
1DA7A84224476EAD008257F0 /* AlertManagerTests.swift in Sources */,
40614101
A91E4C2324F86F1000BE9213 /* CriticalEventLogExportManagerTests.swift in Sources */,
40624102
E9C58A7324DB4A2700487A17 /* LoopDataManagerTests.swift in Sources */,

0 commit comments

Comments
 (0)