Upgrade to KDT 3. (#41)

- Remove v1 to v2 upgrade codepath
- Document how to upgrade from config v1 to v2 for posterity
- Scrub some LiveRamp-specific artifact services

Co-authored-by: Joshua Kwan <joshua.kwan@liveramp.com>

Author: julianvmodesto

documentation/upgrade_v1_to_v2.md

@@ -0,0 +1,20 @@
+
+# Upgrade KDT Config v1 to v2
+
+To upgrade from KDT config v1 to v2, update your Gemfile to
+source v2 of KDT.
+
+```
+source 'https://***REMOVED***'
+
+group :kdt do
+  gem 'kube_deploy_tools', '~> 2'
+end
+```
+
+Then, run the upgrade:
+
+```
+bundle install
+bundle exec kdt upgrade
+```

lib/kube_deploy_tools/deploy_config_file.rb

@@ -9,7 +9,6 @@
 require 'kube_deploy_tools/shellrunner'
 
 DEPLOY_YAML = 'deploy.yaml'
-DEPLOY_YML_V1 = 'deploy.yml'
 
 module KubeDeployTools
   # Read-only model for the deploy.yaml configuration file.
@@ -40,11 +39,6 @@ def initialize(filename)
             filename = DEPLOY_YAML
             config = YAML.load_file(filename)
             break
-          elsif filename.nil? && File.exist?(DEPLOY_YML_V1)
-            Logger.warn('Found deprecated v1 deploy.yml. Please run `kdt upgrade` to v2 deploy.yaml')
-            filename = DEPLOY_YML_V1
-            config = YAML.load_file(filename)
-            break
           end
 
           # KDT should run in the directory containing the deploy config file.
@@ -56,7 +50,7 @@ def initialize(filename)
           if ! filename.nil?
             raise "Could not locate file: config file '#{filename}' in any directory"
           else
-            raise "Could not locate file: config file '#{DEPLOY_YAML}' nor '#{DEPLOY_YML_V1}' in any directory"
+            raise "Could not locate file: config file '#{DEPLOY_YAML}' in any directory"
           end
         end
         if changed_dir
@@ -75,6 +69,8 @@ def initialize(filename)
       case version
       when 2
         fetch_and_parse_version2_config!
+      else
+        raise "Unsupported version #{version}"
       end
     end
 

spec/resources/deploy_v2.yaml

@@ -57,29 +57,6 @@
       expect(config.artifacts).to include(include('name' => 'colo-service-prod'))
       expect(config.artifacts).to include(include('name' => 'us-east-1-prod'))
     end
-
-    it 'outputs the same yaml when trying to upgrade to the current version' do
-      # Convert fixture to yaml, then re-read it
-      Tempfile.open("deploy.yaml from fixture") do |t|
-        fixture = File.open(DEPLOY_YAML) { |f| f.read() }
-        t << fixture
-        t.close
-
-        # Test fixing a v2 yaml: it should do nothing
-        before = KubeDeployTools::DeployConfigFile.new(t.path)
-        before.upgrade!
-
-        # Re-read fixed v1-as-v2 yaml
-        after = KubeDeployTools::DeployConfigFile.new(t.path)
-
-        actual = after
-        expected = config
-
-        expect(actual.artifacts).to eq(expected.artifacts)
-        expect(actual.flavors).to eq(expected.flavors)
-        expect(actual.hooks).to match_array(expected.hooks)
-      end
-    end
   end
 
   context 'deploy.yamls with library files' do

spec/unit/deploy_config_file_spec.rb

@@ -70,7 +70,7 @@
     prefix: local-registry
   - name: gcp
     driver: gcp
-    prefix: ***REMOVED***
+    prefix: gcr.io/my-org
 YAML
     manifest.close
     input_dir = Dir.mktmpdir