Remove deploy logging via Google Cloud Logging (#53)

We will put all our hopes and dreams into Spinnaker audit log.

More importantly, for the sake of OSS it is one less hardcoded reference
to LiveRamp GCP stuff that we have to worry about.

Author: joshk0

bin/deploy

@@ -56,6 +56,5 @@ Dir.mktmpdir do |tmpdir|
   )
   deploy.run(
     dry_run: options.dry_run,
-    send_report: options.send_report
   )
 end

lib/kube_deploy_tools/deploy.rb

@@ -29,10 +29,6 @@
   Service
 ].freeze
 
-# TODO: (aaron): make these configurable
-DEPLOY_LOG = 'projects/***REMOVED***/logs/deploys'
-DEPLOY_PROJECT = '***REMOVED***'
-
 module KubeDeployTools
   class Deploy
     def initialize(
@@ -102,8 +98,7 @@ def do_deploy(dry_run)
       success
     end
 
-    def run(dry_run: true, send_report: true)
-      notify(project_info.merge({'type':'deploy'}).to_json) if !dry_run && send_report
+    def run(dry_run: true)
       do_deploy(dry_run)
     end
 
@@ -216,13 +211,5 @@ def self.kube_namespace(context:, kubeconfig: nil)
     def current_user
       Shellrunner.run_call('gcloud', 'config', 'list', 'account', '--format', 'value(core.account)')[0]
     end
-
-    def notify(message)
-      args = [
-        'gcloud', 'logging', 'write', "--project=#{DEPLOY_PROJECT}",
-        '--payload-type=json', DEPLOY_LOG, message
-      ]
-      Shellrunner.check_call(*args)
-    end
   end
 end

lib/kube_deploy_tools/deploy/options.rb

@@ -13,7 +13,6 @@ class Options
         :artifact,
         :build_number,
         :dry_run,
-        :send_report,
         :glob_files,
         :pre_apply_hook,
         :max_retries,
@@ -23,7 +22,6 @@ def initialize
         self.project = File.basename(`git config remote.origin.url`.chomp, '.git')
         self.flavor = 'default'
         self.dry_run = true
-        self.send_report = true
         self.glob_files = []
       end
 
@@ -80,10 +78,6 @@ def define_options(parser)
           self.pre_apply_hook = p
         end
 
-        parser.on('--send-report SEND_REPORT', TrueClass, "If true, records data about the deploy to a centralized log. Default is #{send_report}") do |p|
-          self.send_report = p
-        end
-
         parser.on('--retry NUM', 'Maximum number of times to retry') do |p|
           self.max_retries = p
         end

spec/unit/deploy_spec.rb

@@ -78,7 +78,6 @@ def parse(ops)
     expect(kubectl).to receive(:run).with('apply', '-f', be_kubernetes_resource_of_kind('Service'), any_args).ordered
     expect(kubectl).to receive(:run).with('apply', '-f', be_kubernetes_resource_of_kind('Deployment'), any_args).ordered
 
-    expect(deploy).to receive(:notify).with(any_args)
     deploy.run(dry_run: false)
   end
 
@@ -123,8 +122,6 @@ def parse(ops)
     expect(kubectl).to receive(:run).with('apply', '-f', be_kubernetes_resource_of_kind('Service'), any_args).ordered.exactly(3).times
     expect(kubectl).to receive(:run).with('apply', '-f', be_kubernetes_resource_of_kind('Deployment'), any_args).ordered.exactly(3).times
 
-    expect(deploy).to receive(:notify).with(any_args)
-
     # Ultimately deploy should fail
     expect {
       deploy.run(dry_run: false)
@@ -222,12 +219,11 @@ def parse(ops)
       build: build_number,
       context: CONTEXT,
       'dry-run': 'false',
-      'send-report': 'false')
+    )
     expect(options.artifact).to match(artifact)
     expect(options.build_number).to match(build_number)
     expect(options.context).to match(CONTEXT)
     expect(options.dry_run).to be(false)
-    expect(options.send_report).to be(false)
 
     from_files = 'bogus/path/'
     options = parse('from-files': from_files,