do not defer close in loop

zyxkad · zyxkad · commit c7eb537b468e · 2024-01-25T09:18:11.000-07:00
diff --git a/cluster_oss.go b/cluster_oss.go
@@ -79,8 +79,9 @@ func (cr *Cluster) CheckFilesOSS(dir string, files []FileInfo, heavy bool, missi
 					logErrorf("Could not open %q: %v", p, err)
 					goto MISSING
 				}
-				defer fd.Close()
-				if _, err = io.Copy(hw, fd); err != nil {
+				_, err = io.Copy(hw, fd)
+				fd.Close()
+				if err != nil {
 					logErrorf("Could not calculate hash for %q: %v", p, err)
 					continue
 				}

Original file line number	Diff line number	Diff line change
`@@ -79,8 +79,9 @@ func (cr *Cluster) CheckFilesOSS(dir string, files []FileInfo, heavy bool, missi`
`79`	`79`	`logErrorf("Could not open %q: %v", p, err)`
`80`	`80`	`goto MISSING`
`81`	`81`	`}`
`82`		`- defer fd.Close()`
`83`		`- if _, err = io.Copy(hw, fd); err != nil {`
	`82`	`+ _, err = io.Copy(hw, fd)`
	`83`	`+ fd.Close()`
	`84`	`+ if err != nil {`
`84`	`85`	`logErrorf("Could not calculate hash for %q: %v", p, err)`
`85`	`86`	`continue`
`86`	`87`	`}`