chore: remove useless package for python engine

Author: ShrBox

src/legacy/main/PythonHelper.cpp

@@ -14,7 +14,6 @@
 #include "utils/Utils.h"
 
 #include <Python.h>
-#include <detours.h>
 #include <engine/TimeTaskSystem.h>
 #include <filesystem>
 #include <toml.h>
@@ -267,51 +266,52 @@ int executePipCommand(std::string cmd) {
 //
 // Attention! When CPython is upgraded, this fix must be re-adapted or removed!!
 //
-namespace FixPython310Stdin {
-// Hard coded function address
-const uintptr_t create_stdio_func_base_offset = 0xCE0F4;
-
-create_stdio_func_type create_stdio_original = nullptr;
-
-PyObject* create_stdio_hooked(
-    const PyConfig* config,
-    PyObject*       io,
-    int             fd,
-    int             write_mode,
-    const char*     name,
-    const wchar_t*  encoding,
-    const wchar_t*  errors
-) {
-    if (fd == 0) {
-        Py_RETURN_NONE;
-    }
-    return create_stdio_original(config, io, fd, write_mode, name, encoding, errors);
-}
-
-bool patchPython310CreateStdio() {
-    if (create_stdio_original == nullptr) {
-        HMODULE hModule = GetModuleHandleW(L"python310.dll");
-        if (hModule == NULL) return false;
-        create_stdio_original = (create_stdio_func_type)(void*)(((uintptr_t)hModule) + create_stdio_func_base_offset);
-    }
-
-    DetourRestoreAfterWith();
-    if (DetourTransactionBegin() != NO_ERROR) return false;
-    else if (DetourUpdateThread(GetCurrentThread()) != NO_ERROR) return false;
-    else if (DetourAttach((PVOID*)&create_stdio_original, create_stdio_hooked) != NO_ERROR) return false;
-    else if (DetourTransactionCommit() != NO_ERROR) return false;
-    return true;
-}
-
-bool unpatchPython310CreateStdio() {
-    if (DetourTransactionBegin() != NO_ERROR) return false;
-    else if (DetourUpdateThread(GetCurrentThread()) != NO_ERROR) return false;
-    else if (DetourDetach((PVOID*)&create_stdio_original, create_stdio_hooked) != NO_ERROR) return false;
-    else if (DetourTransactionCommit() != NO_ERROR) return false;
-    return true;
-}
-
-} // namespace FixPython310Stdin
+// namespace FixPython310Stdin {
+// // Hard coded function address
+// const uintptr_t create_stdio_func_base_offset = 0xCE0F4;
+
+// create_stdio_func_type create_stdio_original = nullptr;
+
+// PyObject* create_stdio_hooked(
+//     const PyConfig* config,
+//     PyObject*       io,
+//     int             fd,
+//     int             write_mode,
+//     const char*     name,
+//     const wchar_t*  encoding,
+//     const wchar_t*  errors
+// ) {
+//     if (fd == 0) {
+//         Py_RETURN_NONE;
+//     }
+//     return create_stdio_original(config, io, fd, write_mode, name, encoding, errors);
+// }
+
+// bool patchPython310CreateStdio() {
+//     if (create_stdio_original == nullptr) {
+//         HMODULE hModule = GetModuleHandleW(L"python310.dll");
+//         if (hModule == NULL) return false;
+//         create_stdio_original = (create_stdio_func_type)(void*)(((uintptr_t)hModule) +
+//         create_stdio_func_base_offset);
+//     }
+
+//     DetourRestoreAfterWith();
+//     if (DetourTransactionBegin() != NO_ERROR) return false;
+//     else if (DetourUpdateThread(GetCurrentThread()) != NO_ERROR) return false;
+//     else if (DetourAttach((PVOID*)&create_stdio_original, create_stdio_hooked) != NO_ERROR) return false;
+//     else if (DetourTransactionCommit() != NO_ERROR) return false;
+//     return true;
+// }
+
+// bool unpatchPython310CreateStdio() {
+//     if (DetourTransactionBegin() != NO_ERROR) return false;
+//     else if (DetourUpdateThread(GetCurrentThread()) != NO_ERROR) return false;
+//     else if (DetourDetach((PVOID*)&create_stdio_original, create_stdio_hooked) != NO_ERROR) return false;
+//     else if (DetourTransactionCommit() != NO_ERROR) return false;
+//     return true;
+// }
+
+// } // namespace FixPython310Stdin
 
 } // namespace PythonHelper
 

src/lse/Entry.cpp

@@ -98,14 +98,6 @@ void initializeLegacyStuff() {
     InitSafeGuardRecord();
     EconomySystem::init();
 #ifdef LEGACY_SCRIPT_ENGINE_BACKEND_PYTHON
-    // This fix is used for Python3.10's bug:
-    // The thread will freeze when creating a new engine while another thread is blocking to read stdin
-    // Side effects: sys.stdin cannot be used after this patch.
-    // More info to see: https://github.com/python/cpython/issues/83526
-    //
-    // Attention! When CPython is upgraded, this fix must be re-adapted or removed!!
-    //
-    PythonHelper::FixPython310Stdin::patchPython310CreateStdio();
     PythonHelper::initPythonRuntime();
 #endif
 

xmake.lua

@@ -28,7 +28,6 @@ elseif is_config("backend", "quickjs") then
 
 elseif is_config("backend", "python") then
     add_requires("scriptx main", {configs={backend="Python"}})
-    add_requires("microsoft-detours")
 
 elseif is_config("backend", "nodejs") then
     add_requires("scriptx main", {configs={backend="V8"}})
@@ -102,7 +101,6 @@ target("legacy-script-engine")
             "LEGACY_SCRIPT_ENGINE_BACKEND_PYTHON"
         )
         set_basename("legacy-script-engine-python")
-        add_packages("microsoft-detours")
 
     elseif is_config("backend", "nodejs") then
         add_defines(