test: system program add hardcoded bump test (#1807)

Author: ananas-block

programs/system/src/accounts/account_checks.rs

@@ -8,7 +8,9 @@ use light_compressed_account::{
 use pinocchio::{account_info::AccountInfo, program_error::ProgramError, pubkey::Pubkey};
 
 use crate::{
-    invoke_cpi::account::CpiContextAccount, processor::sol_compression::SOL_POOL_PDA_SEED, Result,
+    invoke_cpi::account::CpiContextAccount,
+    processor::sol_compression::{SOL_POOL_PDA_BUMP, SOL_POOL_PDA_SEED},
+    Result,
 };
 
 pub fn check_fee_payer(fee_payer: Option<&AccountInfo>) -> Result<&AccountInfo> {
@@ -48,7 +50,7 @@ pub fn check_anchor_option_sol_pool_pda(
         None
     } else {
         check_pda_seeds_with_bump(
-            &[SOL_POOL_PDA_SEED, &[255]][..],
+            &[SOL_POOL_PDA_SEED, &[SOL_POOL_PDA_BUMP]][..],
             &crate::ID,
             option_sol_pool_pda,
         )?;

programs/system/src/constants.rs

@@ -36,3 +36,25 @@ impl TryFrom<&[u8]> for InstructionDiscriminator {
         }
     }
 }
+
+#[cfg(test)]
+mod test {
+    use light_compressed_account::constants::ACCOUNT_COMPRESSION_PROGRAM_ID;
+    use solana_pubkey::Pubkey;
+
+    use super::*;
+
+    fn check_hardcoded_bump(program_id: Pubkey, seeds: &[&[u8]], bump: u8) -> bool {
+        let (_, found_bump) = Pubkey::find_program_address(seeds, &program_id);
+        found_bump == bump
+    }
+
+    #[test]
+    fn test_account_compression_cpi_authority_bump() {
+        assert!(check_hardcoded_bump(
+            ACCOUNT_COMPRESSION_PROGRAM_ID.into(),
+            &[CPI_AUTHORITY_PDA_SEED],
+            CPI_AUTHORITY_PDA_BUMP
+        ));
+    }
+}

programs/system/src/processor/sol_compression.rs

@@ -15,6 +15,7 @@ use crate::{
 #[aligned_sized(anchor)]
 pub struct CompressedSolPda {}
 
+pub const SOL_POOL_PDA_BUMP: u8 = 255;
 pub const SOL_POOL_PDA_SEED: &[u8] = b"sol_pool_pda";
 
 pub fn compress_or_decompress_lamports<
@@ -97,9 +98,30 @@ pub fn compress_lamports<
 }
 
 pub fn transfer_lamports(from: &AccountInfo, to: &AccountInfo, lamports: u64) -> crate::Result<()> {
-    let bump = &[255];
+    let bump = &[SOL_POOL_PDA_BUMP];
     let seed_array = [Seed::from(SOL_POOL_PDA_SEED), Seed::from(bump)];
     let signer = Signer::from(&seed_array);
     let instruction = pinocchio_system::instructions::Transfer { from, to, lamports };
     instruction.invoke_signed(&[signer])
 }
+
+#[cfg(test)]
+mod test {
+    use solana_pubkey::Pubkey;
+
+    use super::*;
+
+    fn check_hardcoded_bump(program_id: Pubkey, seeds: &[&[u8]], bump: u8) -> bool {
+        let (_, found_bump) = Pubkey::find_program_address(seeds, &program_id);
+        found_bump == bump
+    }
+
+    #[test]
+    fn test_check_anchor_option_sol_pool_pda() {
+        assert!(check_hardcoded_bump(
+            crate::ID.into(),
+            &[SOL_POOL_PDA_SEED],
+            SOL_POOL_PDA_BUMP
+        ));
+    }
+}