resolve sonar errors

Author: bjoernranft

core/src/main/java/de/muenchen/allg/itd51/wollmux/form/model/FormModel.java

@@ -107,6 +107,8 @@ public class FormModel
    *          The dialog library.
    * @param presetValues
    *          The values already set in the document.
+   * @param txtDocController
+   *          Instance of TextDocumentController.
    */
   @SuppressWarnings("squid:S3776")
   public FormModel(FormConfig conf, Map<Object, Object> functionContext, FunctionLibrary funcLib,
@@ -147,7 +149,12 @@ public FormModel(FormConfig conf, Map<Object, Object> functionContext, FunctionL
     this.initControls(presetValues);
   }
 
-  public void initControls(Map<String, String> presetValues)
+  /**
+   * Init Controls autofills, trafos and visibilites.
+   * 
+   * @param presetValues
+   */
+  private void initControls(Map<String, String> presetValues)
   {
     // Initialize controls with preset values or AUTOFILL function
     SimpleMap values = idToValue();
@@ -232,14 +239,17 @@ public Map<String, Control> getFormControls()
     return formControls;
   }
 
+  /**
+   * Update visibilites in form ui.
+   */
   public void updateFormControlsVisibility()
   {
     for (Map.Entry<String, Control> entry : this.getFormControls().entrySet())
     {
       for (VisibilityGroup vs: entry.getValue().getGroups())
       {
         //notifiy form gui ui
-        formSidebarController.visibilityChanged(vs.getGroupId(), vs.isVisible());
+        formSidebarController.visibilityChanged(vs.getGroupId());
       }
     }
   }
@@ -285,7 +295,7 @@ public void setValue(final String id, final String value)
             //update vis. in doc
             txtDocController.setVisibilityChanged(g.getGroupId(), g.isVisible());
             //update vis in form-ui
-            formSidebarController.visibilityChanged(g.getGroupId(), g.isVisible());
+            formSidebarController.visibilityChanged(g.getGroupId());
           }
         }
     }

core/src/main/java/de/muenchen/allg/itd51/wollmux/form/sidebar/FormSidebarController.java

@@ -467,6 +467,11 @@ public void buttonPressed(ActionEvent actionEvent)
 
   /**
    * Sets control's text if value changed. Can be called by a dependency to another control.
+   * 
+   * @param id
+   *        Control Id.
+   * @param value
+   *        value to set.       
    */
   public void setFormUiValue(String id, String value)
   {
@@ -480,6 +485,11 @@ public void setFormUiValue(String id, String value)
 
   /**
    * Get notifications if current textfield's value is valid. Colorize if not.
+   * 
+   * @param id
+   *        Control Id.
+   * @param okay
+   *        set okay.
    */
   public void setControlBackground(String id, boolean okay)
   {
@@ -488,8 +498,11 @@ public void setControlBackground(String id, boolean okay)
 
   /**
    * Hide / Show form controls by its new visibility changed status.
+   * 
+   * @param groupId
+   *        The group Id which visibility should be changed.
    */
-  public void visibilityChanged(String groupId, boolean visible)
+  public void visibilityChanged(String groupId)
   {
     Collection<Control> controls = formModel.getControlsByGroupId(groupId);
 
@@ -507,6 +520,9 @@ public void visibilityChanged(String groupId, boolean visible)
     formSidebarPanel.paint();
   }
 
+  /**
+   * Sets preset Values (Formularwerte) in form ui.
+   */
   public void setFormularwerte()
   {
     Map<String,String> formFieldValues = documentController.getFormFieldValues();
@@ -521,6 +537,11 @@ public void setFormularwerte()
     processUIElementEvents = false;
   }
 
+  /**
+   * updates and sets all form control values in form ui.
+   * 
+   * @param formControls
+   */
   public void updateFormUiValues(Map<String,Control> formControls)
   {
     for (String control : formControls.keySet())