Prepare LE to build with cmake 4.0.0

[heitbaum]

Upstream repo already in repo

• libftdi1: patches since 1.5 allowing build with cmake-4.0.0
  • http://developer.intra2net.com/git/?p=libftdi
  • patched with "since 1.5"
• libsndfile: allow build with cmake-4.0.0
  • from upstream
• libarchive
  • [cmake] Require CMake 3.17 or newer libarchive/libarchive#2556
• libevent: allow build with cmake-4.0.0
  • Upgrade required CMake version to 3.5 libevent/libevent#1782
  • Included in the master codebase
• hidapi: allow build with cmake-4.0.0
  • Avoid CMake backward compatibility warning libusb/hidapi#663
• tigervnc
  • in main branch
  • Raise CMake requirement to 3.10 TigerVNC/tigervnc#1366
• libwebsockets
  • main branch of upstream has already been updated
  • https://github.com/warmcat/libwebsockets/blob/main/CMakeLists.txt

Upstream patches raised

• kodi-platform: allow build with cmake-4.0.0
  • Allow build with CMake 4.0.0 xbmc/kodi-platform#31
• media-driver: allow build with cmake-4.0.0
  • [Bug]: Build with cmake-4.0.0 fails intel/media-driver#1918
  • [Media Common] Update cmake_minimum_required to 3.5 consisently across CMakeLists intel/media-driver#1919
• gmmlib: allow build with cmake-4.0.0
  • cmake-4.0.0 requires a minimum of 3.5 in the CMakeLists.txt intel/gmmlib#129
  • Update cmake_minimum_required to 3.5 consisently across CMakeLists intel/gmmlib#130
• rapidjson: allow build with cmake-4.0.0
  • With cmake-4.0.0 now released can this be updated Tencent/rapidjson#2333
  • CMakeLists: increase compatibility. Tencent/rapidjson#2334
• libogg: allow build with cmake-4.0.0
  • https://gitlab.xiph.org/xiph/ogg/-/issues/2304
• lzo: allow build with cmake-4.0.0
  • email sent to oberhumer
• vdr-plugin-robotv: allow build with cmake-4.0.0
  • [cmake] allow build with cmake-4.0.0 pipelka/vdr-plugin-robotv#22
  • Build fails with cmake-4.0.0 pipelka/vdr-plugin-robotv#21
• mariadb: allow build with cmake-4.0.0
  • Update cmake minimum version range for build with cmake 4.0 codership/wsrep-lib#246
  • Add github workflow to check CMake compatibility codership/wsrep-lib#247
  • https://jira.mariadb.org/browse/MDEV-36422
• tini: allow build with cmake-4.0.0
  • tini will fail to build with CMake 4+ krallin/tini#232
  • chore: allow CMake though to 3.10 krallin/tini#233
  • chore: bump minimum CMake to 2.8.12 krallin/tini#206
• yajl: allow build with cmake-4.0.0
  • Allow build with CMake 4.0.0 lloyd/yajl#256
  • update cmake version lloyd/yajl#254
• audiodecoder.dumb: allow build with cmake-4.0.0
  • Allow compile with cmake 4.0.0 xbmc/audiodecoder.dumb#80
• libid3tag
  • https://codeberg.org/tenacityteam/libid3tag/pulls/15
• libde265
  • allow build with cmake-4.0.0 strukturag/libde265#471
  • Building fails with CMake version 4.0.0 or later strukturag/libde265#470
• aixlog
  • Allow build with cmake 4.0.0 badaix/aixlog#19
  • aixlog fails to compile with CMake 4 badaix/aixlog#18
• json-c
  • Allow build with cmake 4.0.0 json-c/json-c#888
• encfs
  • Update minimum CMake version to 3.12; support CMake 4.0 abumq/easyloggingpp#863
  • Allow build with cmake 4.0.0 vgough/encfs#677
• librespot
  • Build fails to complete with cmake-4.0.0 librespot-org/librespot#1479
  • Update Cargo.lock librespot-org/librespot#1480
  • librespot: update to githash 5981b88 and addon (4) #9925
• ldacBT
  • Allow build with CMake 4.0.0 EHfive/ldacBT#1

TBA

• x265
  • https://bitbucket.org/multicoreware/x265_git/issues/988/build-fails-with-cmake-400
  • https://bitbucket.org/multicoreware/x265_git/commits/b354c009a60bcd6d7fc04014e200a1ee9c45c167
  • https://bitbucket.org/multicoreware/x265_git/commits/51ae8e922bcc4586ad4710812072289af91492a8
• oscam
  • https://git.streamboard.tv/common/oscam
  • https://board.streamboard.tv/forum/thread/48547-oscam-fails-to-build-with-cmake-4-0-0/
  • patch written, waiting for git access to submit patch
• hyperhdr
  • Please update lunasvg to allow build with cmake-4.0.0 awawa-dev/HyperHDR#1137
  • Update LunaSVG to v3.1.0 awawa-dev/HyperHDR#1139

Local patch

• hyperion: allow build with cmake-4.0.0
  • unmaintained
  • https://github.com/hyperion-project/hyperion
• p8-platform: allow build with cmake-4.0.0
  • unmaintained
• rcheevos: fix build with cmake-4.0.0
  • local Cmake fix
• soxr: allow build with cmake-4.0.0
  • https://sourceforge.net/p/soxr/code/ci/master/tree/
  • https://sourceforge.net/p/soxr/code/merge-requests/6/

[fuzzard]

You may or may not be aware of https://cmake.org/cmake/help/latest/variable/CMAKE_POLICY_VERSION_MINIMUM.html

It allows to set a "minimum" that will override what a cmake project has its min version at
Adding a define to a configure command will then "avoid" the cmake 4 failure

-DCMAKE_POLICY_VERSION_MINIMUM=3.5

Essentially avoiding having to patch for projects that arent actively maintained (lzo2 is a prime example from kodi perspective).

Cmake state the following in their pre release notes about the new variable

The “CMAKE_POLICY_VERSION_MINIMUM” variable was added to help
packagers and end users try to configure existing projects that have
not been updated to work with supported CMake versions.

Do be aware, cmake devs have stated they intend to make further breaking changes from the 3.x branch (deprecated removals), so setting the minimum to 3.5 in the example above, may need to be revisited in future cmake 4 version bumps if they drop deprecated features in > 3.5

[heitbaum]

You may or may not be aware of https://cmake.org/cmake/help/latest/variable/CMAKE_POLICY_VERSION_MINIMUM.html

It allows to set a "minimum" that will override what a cmake project has its min version at Adding a define to a configure command will then "avoid" the cmake 4 failure

-DCMAKE_POLICY_VERSION_MINIMUM=3.5

Essentially avoiding having to patch for projects that arent actively maintained (lzo2 is a prime example from kodi perspective).

Cmake state the following in their pre release notes about the new variable

The “CMAKE_POLICY_VERSION_MINIMUM” variable was added to help
packagers and end users try to configure existing projects that have
not been updated to work with supported CMake versions.

Do be aware, cmake devs have stated they intend to make further breaking changes from the 3.x branch (deprecated removals), so setting the minimum to 3.5 in the example above, may need to be revisited in future cmake 4 version bumps if they drop deprecated features in > 3.5

I did think about it. I’m regretting not patching some of the gcc-12,13,14… workarounds I had made when we bumped previously, as remembering to clean them up / or revisiting the CFLAGS. So have been on the upstream patch bandwagon for both the gcc15 and now the cmake4.

Some of the patches I have written are 3.10 targeted, which seems to be the not yet deprecated version. When there has been inconsistencies in the version (aka gmmlib and media-driver) then I have just been updating to the consistent.

[fuzzard]

All good. Internally in kodi for other platforms i'll just be using the override for things like lzo.

Just wanted to make sure it was known about a way so you dont have to patch things that are abandoned (or less maintained) upstream and then carry more patches for good

[heitbaum]

All good. Internally in kodi for other platforms i'll just be using the override for things like lzo.

Just wanted to make sure it was known about a way so you dont have to patch things that are abandoned (or less maintained) upstream and then carry more patches for good

You are right. Once we get down to the patches that are/will be accepted, then agree will be time to use the CMAKE_POLICY_VERSION_MINIMUM override

[heitbaum]

@fuzzard - 29 patches required - so not to bad, pretty much all upstreamed, most were simple patches, a couple required rework of the CMakeLists.txt. Let’s see how much traction we get on the upstream merges.