Skip to content

Commit 9df0a0e

Browse files
authored
Merge pull request #156 from JulieWinchester/fix-remove-label-sheet-header
Fix setting removeLabelSheetHeader and header sheet icon toggling
2 parents 110b637 + 67e6eda commit 9df0a0e

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

src/lang/en.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@
7373
"autoHideBottom": "Auto Hide Bottom",
7474
"autoHideBottomHint": "Hide bottom UI(player&hotbar) when actor shows on stage.",
7575
"suppressMacroHotbar": "Show Player List and Macro Hotbar When Stage is Suppressed",
76-
"removeLabelSheetHeader": "Remove label from the header character sheet",
77-
"removeLabelSheetHeaderHint": "Remove label from the header character sheet, Useful for little screen and mobile",
76+
"removeLabelSheetHeader": "Remove Text Labels From Actor Sheet Header",
77+
"removeLabelSheetHeaderHint": "Removes text labels from actor sheet header buttons, useful for small screens and mobile devices. Button will still be displayed with icon.",
7878
"ignoreMessagesToChat": "Ignore Theatre Messages From Chat",
7979
"ignoreMessagesToChatHint": "Ignores messages sent during Theatre Mode from chat. Disabling this message will make them appear again.",
8080
"quoteType": "Quote Type",

src/scripts/Theatre.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8402,8 +8402,8 @@ export class Theatre {
84028402
newText = removeLabel;
84038403
}
84048404
ev.currentTarget.innerHTML = Theatre.isActorStaged(actor)
8405-
? `<i class="fas fa-theater-masks"></i>${newText}`
8406-
: `<i class="fas fa-mask"></i>${newText}`;
8405+
? `<i class="fas fa-mask"></i>${newText}`
8406+
: `<i class="fas fa-theater-masks"></i>${newText}`;
84078407
}
84088408

84098409
static _getTheatreId(actor) {

src/scripts/theatre_main.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,24 +23,27 @@ Handlebars.registerHelper("resprop", function (propPath, hash) {
2323
*/
2424
Hooks.on("getActorSheetHeaderButtons", (app, buttons) => {
2525
if (!game.user.isGM && game.settings.get("theatre", "gmOnly")) return;
26+
const removeLabelSheetHeader = game.settings.get(Theatre.SETTINGS, "removeLabelSheetHeader");
2627

2728
let theatreButtons = [];
2829
if (app.object.isOwner) {
2930
// only prototype actors
3031
if (!app.object.token) {
3132
theatreButtons.push({
32-
label: "Theatre.UI.Config.Theatre",
33+
label: removeLabelSheetHeader ? "" : "Theatre.UI.Config.Theatre",
3334
class: "configure-theatre",
3435
icon: "fas fa-user-edit",
3536
onclick: (ev) => Theatre.onConfigureInsert(ev, app.object.sheet),
3637
});
3738
}
3839
theatreButtons.push({
39-
label: Theatre.isActorStaged(app.object) ? "Theatre.UI.Config.RemoveFromStage" : "Theatre.UI.Config.AddToStage",
40+
label: removeLabelSheetHeader
41+
? ""
42+
: (Theatre.isActorStaged(app.object) ? "Theatre.UI.Config.RemoveFromStage" : "Theatre.UI.Config.AddToStage"),
4043
class: "add-to-theatre-navbar",
41-
icon: "fas fa-theater-masks",
44+
icon: Theatre.isActorStaged(app.object) ? "fas fa-mask" : "fas fa-theater-masks",
4245
onclick: (ev) => {
43-
Theatre.onAddToNavBar(ev, app.object.sheet);
46+
Theatre.onAddToNavBar(ev, app.object.sheet, removeLabelSheetHeader);
4447
},
4548
});
4649
}

0 commit comments

Comments
 (0)