Merge pull request #29 from Latrodect/feature/k8s_best_practice_apply

Bug fix for jobs folder generation

Author: Latrodect

CHANGELOG.md

@@ -10,4 +10,4 @@
 - Jobs generation added for k8s.
 - k8s Folder structure change.
 
-[1.3.0]: https://github.com/Latrodect/Backdoor-VSCode-Extension-for-K8S-Setup-and-Code-Review/releases/tag/v1.2.0
+[1.3.1]: https://github.com/Latrodect/Backdoor-VSCode-Extension-for-K8S-Setup-and-Code-Review/releases/tag/v1.3.1

out/commands/generateKubernetesFiles.js

@@ -4,7 +4,7 @@
   "description": "K8S and Docker Structure generator. Online code reviewer.",
   "publisher": "Pilliage",
   "icon": "images/backdoor.png",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "repository": {
     "type": "git",
     "url": "https://github.com/Latrodect/Backdoor-VSCode-Extension-for-K8S-Setup-and-Code-Review"

out/commands/generateKubernetesFiles.js.map

@@ -45,10 +45,7 @@ export async function generateKubernetesFiles() {
       vscode.window.showInformationMessage('Jobs Folder not created.');
 
   } 
-    let jobNames: string[] = []
-    if(jobsInput){
-    jobNames = checkSpacesAndReplace(jobsInput.split(',').map(name => name.trim()));
-    }
+    
 
     // Folder Generation
     const kubernetesFolder = vscode.Uri.joinPath(vscode.workspace.workspaceFolders[0].uri, 'kubernetes');
@@ -65,8 +62,7 @@ export async function generateKubernetesFiles() {
     const secretsFolder = vscode.Uri.joinPath(kubernetesFolder, 'secrets');
     fs.mkdirSync(secretsFolder.fsPath, { recursive: true });
 
-    const jobsFolder = vscode.Uri.joinPath(kubernetesFolder, 'jobs');
-    fs.mkdirSync(jobsFolder.fsPath, { recursive: true });
+    
 
     // Deployment Yaml fs operations
     const namespaceYAML = `
@@ -170,29 +166,36 @@ data:
     vscode.window.showInformationMessage(`${deploymentNames.length} deployment, service, and ingress files generated successfully.`);
 
     // Jobs Yaml fs operations
-    const jobPromises = jobNames.map(async jobNames => {})
-    const jobYAML = `
+    if(jobsInput){
+      const jobsFolder = vscode.Uri.joinPath(kubernetesFolder, 'jobs');
+      fs.mkdirSync(jobsFolder.fsPath, { recursive: true });
+      
+      const jobNames = checkSpacesAndReplace(jobsInput.split(',').map(name => name.trim()));
+    
+      const jobPromises = jobNames.map(async jobName => {
+      const jobYAML = `
 apiVersion: batch/v1
 kind: Job
 metadata:
-  name: ${jobNames}
+  name: ${jobName}
 spec:
   completions: 1
   template:
     metadata:
-      name: ${jobNames}-pod
+      name: ${jobName}-pod
     spec:
       containers:
-        - name: ${jobNames}-container
+        - name: ${jobName}-container
           image: nginx
       restartPolicy: Never
   
         `;
-    await writeFileWithDirectoryCheck(path.join(jobsFolder.fsPath, `${jobNames}-job.yaml`), jobYAML);
-
+      await writeFileWithDirectoryCheck(path.join(jobsFolder.fsPath, `${jobName}-job.yaml`), jobYAML);
+  })
     await Promise.all(jobPromises);
     vscode.window.showInformationMessage(`${jobNames.length} deployment, service, and ingress files generated successfully.`);
   }
+}
 
 async function writeFileWithDirectoryCheck(filePath: string, content: string) {
   const folderPath = path.dirname(filePath);