Fixed validation of numeric strings. These will and must be strictly handled as strings to support a numeric string _key.

Author: LaravelFreelancerNL

.github/workflows/coverage.yml

@@ -13,7 +13,7 @@ jobs:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '7.2'
+          php-version: '7.4'
           extensions: mbstring, intl
           ini-values: post_max_size=256M, short_open_tag=On
           coverage: xdebug

src/Traits/ValidatesExpressions.php

@@ -79,7 +79,7 @@ public function isNull($value): bool
      */
     public function isNumber($value): bool
     {
-        return is_numeric($value);
+        return is_numeric($value) && !is_string($value);
     }
 
     /**

tests/Unit/AQL/OperatorExpressionsTest.php

@@ -14,7 +14,7 @@ class OperatorExpressionsTest extends TestCase
     public function testIf()
     {
         $qb = new QueryBuilder();
-        $qb->let('x', 5)->return($qb->if(['x', '==', '5'], true, false));
+        $qb->let('x', 5)->return($qb->if(['x', '==', 5], true, false));
         self::assertEquals("LET x = 5 RETURN (x == 5) ? true : false", $qb->get()->query);
     }
 

tests/Unit/GrammarTest.php

@@ -293,6 +293,9 @@ public function testIsNumeric()
 
         $result = $this->grammar->isNumber('string');
         self::assertFalse($result);
+
+        $result = $this->grammar->isNumber('1');
+        self::assertFalse($result);
     }
 
     public function testFormatBind()