[cleanup] SMN Petskills plumbing

[MowFord]

This code should be able to be ripped out since all smn petskills go through pet_skills.sql as of a while now

• Legacy mp calculation for blood pacts. They are all done in the job_utils now

  • server/src/map/entities/charentity.cpp

    Line 1707 in 263b4c4

    // TODO: Remove me when all pet abilities are ported to PetSkill

• Legacy flow for pulling mobskill data to infer avatar bp data

  • server/src/map/entities/charentity.cpp

    Line 1888 in 263b4c4

    else if (PPet) // may be a bp, fallback - don't display msg and notify pet

just as an aside, i'm pretty sure

server/src/map/entities/charentity.cpp

Line 1962 in 263b4c4

// TODO: make this generic enough to not require an if

and

server/src/map/entities/charentity.cpp

Line 2007 in 263b4c4

else

are only used for jug pet ready skills, so should be able to rip those out once all jug petskills are migrated. But that's more just information for the reader.

[github-actions]

✨ Hello and thanks for the report! ✨

🤖: This is a friendly automated reminder that the maintainers won't look at your report until you've properly completed all of the checkboxes in the pre-filled template.