From d1dce8b25ef6f37bc21f7799a902e0d637585241 Mon Sep 17 00:00:00 2001 From: Samuel Fendell Date: Tue, 28 May 2024 10:19:35 -0700 Subject: [PATCH] Throw ResourceNotFound error when deleting nonexistant model config --- libs/labelbox/src/labelbox/client.py | 2 ++ libs/labelbox/tests/integration/test_model_config.py | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/libs/labelbox/src/labelbox/client.py b/libs/labelbox/src/labelbox/client.py index 0d07c1134..5ad843b89 100644 --- a/libs/labelbox/src/labelbox/client.py +++ b/libs/labelbox/src/labelbox/client.py @@ -650,6 +650,8 @@ def delete_model_config(self, id: str) -> bool: }""" params = {"id": id} result = self.execute(query, params) + if not result: + raise labelbox.exceptions.ResourceNotFoundError(Entity.ModelConfig, params) return result['deleteModelConfig']['success'] def create_dataset(self, diff --git a/libs/labelbox/tests/integration/test_model_config.py b/libs/labelbox/tests/integration/test_model_config.py index 9c20dea6f..960b096c6 100644 --- a/libs/labelbox/tests/integration/test_model_config.py +++ b/libs/labelbox/tests/integration/test_model_config.py @@ -1,4 +1,5 @@ import pytest +from labelbox.exceptions import ResourceNotFoundError def test_create_model_config(client, valid_model_id): model_config = client.create_model_config("model_config", valid_model_id, {"param": "value"}) @@ -10,3 +11,7 @@ def test_create_model_config(client, valid_model_id): def test_delete_model_config(client, valid_model_id): model_config_id = client.create_model_config("model_config", valid_model_id, {"param": "value"}) assert(client.delete_model_config(model_config_id.uid)) + +def test_delete_nonexistant_model_config(client): + with pytest.raises(ResourceNotFoundError): + client.delete_model_config("invalid_model_id")