Make set_regenerate_conversations_after_incorrect_step and set_rate_alternative_responses configurable by the user

Val Brodsky · Val Brodsky · commit c5e133d8eafb · 2024-10-28T13:53:50.000-07:00
diff --git a/libs/labelbox/src/labelbox/schema/tool_building/step_reasoning_tool.py b/libs/labelbox/src/labelbox/schema/tool_building/step_reasoning_tool.py
@@ -171,8 +171,6 @@ def set_rate_alternative_responses(self):
         )
 
     def asdict(self) -> Dict[str, Any]:
-        self.set_rate_alternative_responses()
-        self.set_regenerate_conversations_after_incorrect_step()
         return {
             "tool": self.type.value,
             "name": self.name,
diff --git a/libs/labelbox/tests/integration/test_ontology.py b/libs/labelbox/tests/integration/test_ontology.py
@@ -339,7 +339,7 @@ def test_step_reasoning_ontology(chat_evaluation_ontology):
         {
             "id": 2,
             "name": "Incorrect",
-            "actions": ["regenerateSteps", "generateAndRateAlternativeSteps"],
+            "actions": [],
         },
     ]
     assert step_reasoning_tool["definition"]["version"] == 1
@@ -364,6 +364,6 @@ def test_step_reasoning_ontology(chat_evaluation_ontology):
         {
             "id": 2,
             "name": "Incorrect",
-            "actions": ["regenerateSteps", "generateAndRateAlternativeSteps"],
+            "actions": [],
         },
     ]
diff --git a/libs/labelbox/tests/unit/test_unit_step_reasoning_tool.py b/libs/labelbox/tests/unit/test_unit_step_reasoning_tool.py
@@ -16,10 +16,7 @@ def test_step_reasoning_as_dict_default():
                 {
                     "id": 2,
                     "name": "Incorrect",
-                    "actions": [
-                        "regenerateSteps",
-                        "generateAndRateAlternativeSteps",
-                    ],
+                    "actions": [],
                 },
             ],
             "version": 1,

Original file line number	Diff line number	Diff line change
`@@ -171,8 +171,6 @@ def set_rate_alternative_responses(self):`
`171`	`171`	`)`
`172`	`172`
`173`	`173`	`def asdict(self) -> Dict[str, Any]:`
`174`		`- self.set_rate_alternative_responses()`
`175`		`- self.set_regenerate_conversations_after_incorrect_step()`
`176`	`174`	`return {`
`177`	`175`	`"tool": self.type.value,`
`178`	`176`	`"name": self.name,`
Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,7 @@ def test_step_reasoning_ontology(chat_evaluation_ontology):`
`339`	`339`	`{`
`340`	`340`	`"id": 2,`
`341`	`341`	`"name": "Incorrect",`
`342`		`- "actions": ["regenerateSteps", "generateAndRateAlternativeSteps"],`
	`342`	`+ "actions": [],`
`343`	`343`	`},`
`344`	`344`	`]`
`345`	`345`	`assert step_reasoning_tool["definition"]["version"] == 1`
`@@ -364,6 +364,6 @@ def test_step_reasoning_ontology(chat_evaluation_ontology):`
`364`	`364`	`{`
`365`	`365`	`"id": 2,`
`366`	`366`	`"name": "Incorrect",`
`367`		`- "actions": ["regenerateSteps", "generateAndRateAlternativeSteps"],`
	`367`	`+ "actions": [],`
`368`	`368`	`},`
`369`	`369`	`]`