Skip to content

Commit a1f1ec4

Browse files
author
Val Brodsky
committed
Fixing more tests
1 parent fdb768d commit a1f1ec4

File tree

4 files changed

+10
-12
lines changed

4 files changed

+10
-12
lines changed

libs/labelbox/tests/data/annotation_import/conftest.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -622,12 +622,15 @@ def configured_project(client, initial_dataset, ontology, rand_gen, image_url):
622622
data_row_ids = []
623623

624624
ontologies = ontology["tools"] + ontology["classifications"]
625+
data_row_data = []
625626
for ind in range(len(ontologies)):
626-
data_row_ids.append(
627-
dataset.create_data_row(
628-
row_data=image_url,
629-
global_key=f"gk_{ontologies[ind]['name']}_{rand_gen(str)}",
630-
).uid)
627+
data_row_data.append({
628+
"row_data": image_url,
629+
"global_key": f"gk_{ontologies[ind]['name']}_{rand_gen(str)}"
630+
})
631+
task = dataset.create_data_rows(data_row_data)
632+
task.wait_till_done()
633+
data_row_ids = [row['id'] for row in task.result]
631634
project._wait_until_data_rows_are_processed(data_row_ids=data_row_ids,
632635
sleep_interval=3)
633636

libs/labelbox/tests/integration/test_data_rows.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -362,10 +362,6 @@ def test_create_data_row_with_invalid_input(dataset, image_url):
362362
with pytest.raises(ResourceCreationError) as exc:
363363
dataset.create_data_row("asdf")
364364

365-
dr = {"row_data": image_url}
366-
with pytest.raises(ResourceCreationError) as exc:
367-
dataset.create_data_row(dr, row_data=image_url)
368-
369365

370366
def test_create_data_row_with_metadata(mdo, dataset, image_url):
371367
client = dataset.client

libs/labelbox/tests/integration/test_dataset.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import requests
33
from unittest.mock import MagicMock
44
from labelbox import Dataset
5-
from labelbox.exceptions import ResourceNotFoundError, InvalidQueryError
5+
from labelbox.exceptions import ResourceNotFoundError, ResourceCreationError
66

77
from labelbox.schema.internal.descriptor_file_creator import DescriptorFileCreator
88

@@ -128,7 +128,7 @@ def test_create_pdf(dataset):
128128
},
129129
media_type="PDF")
130130

131-
with pytest.raises(InvalidQueryError):
131+
with pytest.raises(ResourceCreationError):
132132
# Wrong media type
133133
dataset.create_data_row(row_data={
134134
"pdfUrl":

libs/labelbox/tests/integration/test_project_model_config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
from _pytest import config
21
import pytest
32
from labelbox.exceptions import ResourceNotFoundError
43

0 commit comments

Comments
 (0)