Skip to content

Commit 8f3b650

Browse files
Throw ResourceNotFound error when deleting nonexistant model config (#1634)
1 parent 2e717c8 commit 8f3b650

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

libs/labelbox/src/labelbox/client.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -650,6 +650,8 @@ def delete_model_config(self, id: str) -> bool:
650650
}"""
651651
params = {"id": id}
652652
result = self.execute(query, params)
653+
if not result:
654+
raise labelbox.exceptions.ResourceNotFoundError(Entity.ModelConfig, params)
653655
return result['deleteModelConfig']['success']
654656

655657
def create_dataset(self,

libs/labelbox/tests/integration/test_model_config.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import pytest
2+
from labelbox.exceptions import ResourceNotFoundError
23

34
def test_create_model_config(client, valid_model_id):
45
model_config = client.create_model_config("model_config", valid_model_id, {"param": "value"})
@@ -10,3 +11,7 @@ def test_create_model_config(client, valid_model_id):
1011
def test_delete_model_config(client, valid_model_id):
1112
model_config_id = client.create_model_config("model_config", valid_model_id, {"param": "value"})
1213
assert(client.delete_model_config(model_config_id.uid))
14+
15+
def test_delete_nonexistant_model_config(client):
16+
with pytest.raises(ResourceNotFoundError):
17+
client.delete_model_config("invalid_model_id")

0 commit comments

Comments
 (0)