Skip to content

Commit 7e52c76

Browse files
committed
Start showing CLI deprecation warnings (e.g. “warning: after [date] you will no longer be able to use x.”)
1 parent 0b81083 commit 7e52c76

File tree

2 files changed

+23
-13
lines changed

2 files changed

+23
-13
lines changed

labelbox/schema/data_row_metadata.py

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@ class DataRowMetadataSchema(BaseModel):
3232

3333
@property
3434
def id(self):
35+
"""
36+
"DataRowMetadataSchema.id is being deprecated after version 3.9
37+
in favor of DataRowMetadataSchema.uid"
38+
"""
3539
warnings.warn("`id` is being deprecated in favor of `uid`")
3640
return self.uid
3741

@@ -43,7 +47,6 @@ def id(self):
4347

4448

4549
class _CamelCaseMixin(BaseModel):
46-
4750
class Config:
4851
allow_population_by_field_name = True
4952
alias_generator = camel_case
@@ -109,7 +112,6 @@ class DataRowMetadataOntology:
109112
>>> mdo = client.get_data_row_metadata_ontology()
110113
111114
"""
112-
113115
def __init__(self, client):
114116

115117
self._client = client
@@ -129,8 +131,8 @@ def _build_ontology(self):
129131
]
130132
self.reserved_by_id = self._make_id_index(self.reserved_fields)
131133
self.reserved_by_name: Dict[
132-
str,
133-
DataRowMetadataSchema] = self._make_name_index(self.reserved_fields)
134+
str, DataRowMetadataSchema] = self._make_name_index(
135+
self.reserved_fields)
134136

135137
# custom fields
136138
self.custom_fields: List[DataRowMetadataSchema] = [
@@ -206,9 +208,8 @@ def _parse_ontology(raw_ontology) -> List[DataRowMetadataSchema]:
206208
return fields
207209

208210
def parse_metadata(
209-
self, unparsed: List[Dict[str,
210-
List[Union[str,
211-
Dict]]]]) -> List[DataRowMetadata]:
211+
self, unparsed: List[Dict[str, List[Union[str, Dict]]]]
212+
) -> List[DataRowMetadata]:
212213
""" Parse metadata responses
213214
214215
>>> mdo.parse_metadata([metdata])
@@ -301,8 +302,8 @@ def _batch_upsert(
301302
data_row_id=m.data_row_id,
302303
fields=list(
303304
chain.from_iterable(
304-
self._parse_upsert(m) for m in m.fields))).dict(
305-
by_alias=True))
305+
self._parse_upsert(m)
306+
for m in m.fields))).dict(by_alias=True))
306307

307308
res = _batch_operations(_batch_upsert, items, self._batch_size)
308309
return res
@@ -468,11 +469,12 @@ def _batch_operations(
468469

469470

470471
def _validate_parse_embedding(
471-
field: DataRowMetadataField
472+
field: DataRowMetadataField
472473
) -> List[Dict[str, Union[SchemaId, Embedding]]]:
473474

474475
if isinstance(field.value, list):
475-
if not (Embedding.min_items <= len(field.value) <= Embedding.max_items):
476+
if not (Embedding.min_items <= len(field.value) <=
477+
Embedding.max_items):
476478
raise ValueError(
477479
"Embedding length invalid. "
478480
"Must have length within the interval "

labelbox/schema/model_run.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ def add_predictions(
123123
return MEAPredictionImport.create_from_file(
124124
path=str(predictions), **kwargs)
125125
else:
126-
return MEAPredictionImport.create_from_url(url=str(predictions),
127-
**kwargs)
126+
return MEAPredictionImport.create_from_url(
127+
url=str(predictions), **kwargs)
128128
elif isinstance(predictions, Iterable):
129129
return MEAPredictionImport.create_from_objects(
130130
predictions=predictions, **kwargs)
@@ -145,6 +145,10 @@ def model_run_data_rows(self):
145145
['annotationGroups', 'pageInfo', 'endCursor'])
146146

147147
def annotation_groups(self):
148+
"""
149+
"ModelRun.annotation_groups is being deprecated after version 3.9
150+
in favor of ModelRun.model_run_data_rows"
151+
"""
148152
warnings.warn(
149153
"`ModelRun.annotation_groups` is being deprecated in favor of `ModelRun.model_run_data_rows`"
150154
)
@@ -181,6 +185,10 @@ def delete_model_run_data_rows(self, data_row_ids):
181185
})
182186

183187
def delete_annotation_groups(self, data_row_ids):
188+
"""
189+
"ModelRun.delete_annotation_groups is being deprecated after version 3.9
190+
in favor of ModelRun.delete_model_run_data_rows"
191+
"""
184192
warnings.warn(
185193
"`ModelRun.delete_annotation_groups` is being deprecated in favor of `ModelRun.delete_model_run_data_rows`"
186194
)

0 commit comments

Comments
 (0)