Skip to content

Commit 71e4f60

Browse files
author
gdj0nes
committed
FIX: small test case fixes
1 parent 5440355 commit 71e4f60

File tree

2 files changed

+16
-15
lines changed

2 files changed

+16
-15
lines changed

labelbox/schema/data_row_metadata.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,30 +39,30 @@ class DataRowMetadataSchema(BaseModel):
3939
DataRowMetadataValue = Union[Embedding, DateTime, String, OptionId]
4040

4141

42-
class CamelCaseMixin(BaseModel):
42+
class _CamelCaseMixin(BaseModel):
4343

4444
class Config:
4545
allow_population_by_field_name = True
4646
alias_generator = camel_case
4747

4848

4949
# Metadata base class
50-
class DataRowMetadataField(CamelCaseMixin):
50+
class DataRowMetadataField(_CamelCaseMixin):
5151
schema_id: SchemaId
5252
value: DataRowMetadataValue
5353

5454

55-
class DataRowMetadata(CamelCaseMixin):
55+
class DataRowMetadata(_CamelCaseMixin):
5656
data_row_id: str
5757
fields: List[DataRowMetadataField]
5858

5959

60-
class DeleteDataRowMetadata(CamelCaseMixin):
60+
class DeleteDataRowMetadata(_CamelCaseMixin):
6161
data_row_id: str
6262
fields: List[SchemaId]
6363

6464

65-
class DataRowMetadataBatchResponse(CamelCaseMixin):
65+
class DataRowMetadataBatchResponse(_CamelCaseMixin):
6666
data_row_id: str
6767
error: str
6868
fields: List[Union[DataRowMetadataField, SchemaId]]
@@ -73,18 +73,18 @@ class DataRowMetadataBatchResponse(CamelCaseMixin):
7373

7474

7575
# Bulk upsert values
76-
class _UpsertDataRowMetadataInput(CamelCaseMixin):
76+
class _UpsertDataRowMetadataInput(_CamelCaseMixin):
7777
schema_id: str
7878
value: Union[str, List, dict]
7979

8080

8181
# Batch of upsert values for a datarow
82-
class _UpsertBatchDataRowMetadata(CamelCaseMixin):
82+
class _UpsertBatchDataRowMetadata(_CamelCaseMixin):
8383
data_row_id: str
8484
fields: List[_UpsertDataRowMetadataInput]
8585

8686

87-
class _DeleteBatchDataRowMetadata(CamelCaseMixin):
87+
class _DeleteBatchDataRowMetadata(_CamelCaseMixin):
8888
data_row_id: str
8989
schema_ids: List[SchemaId]
9090

@@ -238,7 +238,7 @@ def bulk_upsert(
238238
An empty list means the upload was successful.
239239
"""
240240

241-
if not (len(metadata)):
241+
if not len(metadata):
242242
raise ValueError("Empty list passed")
243243

244244
def _batch_upsert(

tests/integration/test_data_row_metadata.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ def test_bulk_delete_datarow_metadata(datarow, mdo):
102102
assert not len(datarow.metadata["fields"])
103103

104104
metadata = make_metadata(datarow.uid)
105+
mdo.bulk_upsert([metadata])
105106

106107
assert len(datarow.metadata["fields"])
107108

@@ -228,25 +229,25 @@ def test_large_bulk_delete_non_existent_schema_id(big_dataset, mdo):
228229

229230
def test_parse_raw_metadata(mdo):
230231
example = {
231-
'dataRowId':
232+
'data_row_id':
232233
'ckr6kkfx801ui0yrtg9fje8xh',
233234
'fields': [{
234-
'schemaId': 'cko8s9r5v0001h2dk9elqdidh',
235+
'schema_id': 'cko8s9r5v0001h2dk9elqdidh',
235236
'value': 'my-new-message'
236237
}, {
237-
'schemaId': 'cko8sbczn0002h2dkdaxb5kal',
238+
'schema_id': 'cko8sbczn0002h2dkdaxb5kal',
238239
'value': {}
239240
}, {
240-
'schemaId': 'cko8sbscr0003h2dk04w86hof',
241+
'schema_id': 'cko8sbscr0003h2dk04w86hof',
241242
'value': {}
242243
}, {
243-
'schemaId': 'cko8sdzv70006h2dk8jg64zvb',
244+
'schema_id': 'cko8sdzv70006h2dk8jg64zvb',
244245
'value': '2021-07-20T21:41:14.606710Z'
245246
}]
246247
}
247248

248249
parsed = mdo.parse_metadata([example])
249250
assert len(parsed) == 1
250251
row = parsed[0]
251-
assert row.data_row_id == example["dataRowId"]
252+
assert row.data_row_id == example["data_row_id"]
252253
assert len(row.fields) == 3

0 commit comments

Comments
 (0)