Skip to content

Commit 5ee9ba8

Browse files
author
Val Brodsky
committed
Optimize some tests to create data rows in batch instead of 1 at a time
1 parent 469fc0f commit 5ee9ba8

File tree

1 file changed

+15
-7
lines changed

1 file changed

+15
-7
lines changed

libs/labelbox/tests/integration/test_global_keys.py

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,22 +108,30 @@ def test_long_global_key_validation(client, dataset, image_url):
108108

109109

110110
def test_global_key_with_whitespaces_validation(client, dataset, image_url):
111-
dr_1 = dataset.create_data_row(row_data=image_url)
112-
dr_2 = dataset.create_data_row(row_data=image_url)
113-
dr_3 = dataset.create_data_row(row_data=image_url)
111+
data_row_items = [{
112+
"row_data": image_url,
113+
}, {
114+
"row_data": image_url,
115+
}, {
116+
"row_data": image_url,
117+
}]
118+
task = dataset.create_data_rows(data_row_items)
119+
task.wait_till_done()
120+
assert task.status == "COMPLETE"
121+
dr_1_uid, dr_2_uid, dr_3_uid = [t['id'] for t in task.result]
114122

115123
gk_1 = ' global key'
116124
gk_2 = 'global key'
117125
gk_3 = 'global key '
118126

119127
assignment_inputs = [{
120-
"data_row_id": dr_1.uid,
128+
"data_row_id": dr_1_uid,
121129
"global_key": gk_1
122130
}, {
123-
"data_row_id": dr_2.uid,
131+
"data_row_id": dr_2_uid,
124132
"global_key": gk_2
125133
}, {
126-
"data_row_id": dr_3.uid,
134+
"data_row_id": dr_3_uid,
127135
"global_key": gk_3
128136
}]
129137
res = client.assign_global_keys_to_data_rows(assignment_inputs)
@@ -134,7 +142,7 @@ def test_global_key_with_whitespaces_validation(client, dataset, image_url):
134142
assign_errors_ids = set([e['data_row_id'] for e in res['errors']])
135143
assign_errors_gks = set([e['global_key'] for e in res['errors']])
136144
assign_errors_msgs = set([e['error'] for e in res['errors']])
137-
assert assign_errors_ids == set([dr_1.uid, dr_2.uid, dr_3.uid])
145+
assert assign_errors_ids == set([dr_1_uid, dr_2_uid, dr_3_uid])
138146
assert assign_errors_gks == set([gk_1, gk_2, gk_3])
139147
assert assign_errors_msgs == set([
140148
'Invalid assignment. Either DataRow does not exist, or globalKey is invalid',

0 commit comments

Comments
 (0)