Skip to content

Commit 5850d6c

Browse files
author
Val Brodsky
committed
Make it backward-compatible
1 parent 1b2c520 commit 5850d6c

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

libs/labelbox/src/labelbox/client.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -914,8 +914,8 @@ def create_model_evaluation_project(
914914
@overload
915915
def create_model_evaluation_project(
916916
self,
917-
dataset_id: str,
918-
dataset_name: str = None,
917+
dataset_id: Optional[str] = None,
918+
dataset_name: Optional[str] = None,
919919
data_row_count: Optional[int] = None,
920920
**kwargs,
921921
) -> Project:
@@ -957,16 +957,21 @@ def create_model_evaluation_project(
957957
raise ValueError("data_row_count must be a positive integer.")
958958

959959
autogenerate_data_rows = False
960-
if dataset_id:
960+
if dataset_id or dataset_name or data_row_count:
961+
warnings.warn(
962+
"Automatic generation of data rows of live model evaluation projects is deprecated. dataset_name_or_id, append_to_existing_dataset, data_row_count will be removed in a future version.",
963+
DeprecationWarning,
964+
)
961965
autogenerate_data_rows = True
966+
967+
if dataset_id:
962968
append_to_existing_dataset = True
963969
dataset_name_or_id = dataset_id
964970
warnings.warn(
965971
"Automatic generation of data rows of live model evaluation projects is deprecated. dataset_name_or_id will be removed in a future version.",
966972
DeprecationWarning,
967973
)
968974
elif dataset_name:
969-
autogenerate_data_rows = True
970975
append_to_existing_dataset = False
971976
dataset_name_or_id = dataset_name
972977
warnings.warn(

0 commit comments

Comments
 (0)