Skip to content

Commit 516c6f9

Browse files
authored
Fixed name of a step for step reasoning (#1896)
1 parent 3a06ec5 commit 516c6f9

File tree

3 files changed

+24
-12
lines changed

3 files changed

+24
-12
lines changed

libs/labelbox/src/labelbox/schema/tool_building/step_reasoning_tool.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class IncorrectStepReasoningVariant:
2121
name: str
2222
regenerate_steps: Optional[bool] = True
2323
generate_and_rate_alternative_steps: Optional[bool] = True
24-
rewrite_steps: Optional[bool] = True
24+
rewrite_step: Optional[bool] = True
2525
justification: Optional[bool] = True
2626

2727
def asdict(self) -> Dict[str, Any]:
@@ -30,8 +30,8 @@ def asdict(self) -> Dict[str, Any]:
3030
actions.append("regenerateSteps")
3131
if self.generate_and_rate_alternative_steps:
3232
actions.append("generateAndRateAlternativeSteps")
33-
if self.rewrite_steps:
34-
actions.append("rewriteSteps")
33+
if self.rewrite_step:
34+
actions.append("rewriteStep")
3535
if self.justification:
3636
actions.append("justification")
3737
return {"id": self.id, "name": self.name, "actions": actions}
@@ -46,7 +46,7 @@ def from_dict(
4646
regenerate_steps="regenerateSteps" in dictionary.get("actions", []),
4747
generate_and_rate_alternative_steps="generateAndRateAlternativeSteps"
4848
in dictionary.get("actions", []),
49-
rewrite_steps="rewriteSteps" in dictionary.get("actions", []),
49+
rewrite_step="rewriteStep" in dictionary.get("actions", []),
5050
justification="justification" in dictionary.get("actions", []),
5151
)
5252

@@ -183,11 +183,11 @@ def reset_generate_and_rate_alternative_steps(self):
183183
"""
184184
self.definition.variants.incorrect_step.generate_and_rate_alternative_steps = False
185185

186-
def reset_rewrite_steps(self):
186+
def reset_rewrite_step(self):
187187
"""
188188
For live models, will require labelers to rewrite the conversation
189189
"""
190-
self.definition.variants.incorrect_step.rewrite_steps = False
190+
self.definition.variants.incorrect_step.rewrite_step = False
191191

192192
def reset_justification(self):
193193
"""

libs/labelbox/tests/integration/test_ontology.py

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -334,12 +334,17 @@ def test_step_reasoning_ontology(chat_evaluation_ontology):
334334
break
335335
assert step_reasoning_tool is not None
336336
assert step_reasoning_tool["definition"]["variants"] == [
337-
{"id": 0, "name": "Correct"},
338-
{"id": 1, "name": "Neutral"},
337+
{"id": 0, "name": "Correct", "actions": []},
338+
{"id": 1, "name": "Neutral", "actions": []},
339339
{
340340
"id": 2,
341341
"name": "Incorrect",
342-
"actions": ["regenerateSteps", "generateAndRateAlternativeSteps"],
342+
"actions": [
343+
"regenerateSteps",
344+
"generateAndRateAlternativeSteps",
345+
"rewriteStep",
346+
"justification",
347+
],
343348
},
344349
]
345350
assert step_reasoning_tool["definition"]["version"] == 1
@@ -356,14 +361,21 @@ def test_step_reasoning_ontology(chat_evaluation_ontology):
356361
{
357362
"id": 0,
358363
"name": "Correct",
364+
"actions": [],
359365
},
360366
{
361367
"id": 1,
362368
"name": "Neutral",
369+
"actions": [],
363370
},
364371
{
365372
"id": 2,
366373
"name": "Incorrect",
367-
"actions": ["regenerateSteps", "generateAndRateAlternativeSteps"],
374+
"actions": [
375+
"regenerateSteps",
376+
"generateAndRateAlternativeSteps",
377+
"rewriteStep",
378+
"justification",
379+
],
368380
},
369381
]

libs/labelbox/tests/unit/test_unit_step_reasoning_tool.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def test_step_reasoning_as_dict_default():
1919
"actions": [
2020
"regenerateSteps",
2121
"generateAndRateAlternativeSteps",
22-
"rewriteSteps",
22+
"rewriteStep",
2323
"justification",
2424
],
2525
},
@@ -33,7 +33,7 @@ def test_step_reasoning_as_dict_with_actions():
3333
tool = StepReasoningTool(name="step reasoning")
3434
tool.reset_generate_and_rate_alternative_steps()
3535
tool.reset_regenerate_steps()
36-
tool.reset_rewrite_steps()
36+
tool.reset_rewrite_step()
3737
tool.reset_justification()
3838
assert tool.asdict() == {
3939
"tool": "step-reasoning",

0 commit comments

Comments
 (0)