Skip to content

Commit 33983c1

Browse files
vbrodskyVal Brodsky
authored andcommitted
Vb/remove p3.8 plt 502 (#1847)
1 parent 58700f5 commit 33983c1

35 files changed

+65
-145
lines changed

.github/actions/lbox-matrix/index.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26811,11 +26811,6 @@ const core = __nccwpck_require__(8611);
2681126811
try {
2681226812
const files = JSON.parse(core.getInput('files-changed'));
2681326813
const startingMatrix = [
26814-
{
26815-
"python-version": "3.8",
26816-
"api-key": "STAGING_LABELBOX_API_KEY_2",
26817-
"da-test-key": "DA_GCP_LABELBOX_API_KEY"
26818-
},
2681926814
{
2682026815
"python-version": "3.9",
2682126816
"api-key": "STAGING_LABELBOX_API_KEY_3",

.github/workflows/lbox-develop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ jobs:
9090
- uses: ./.github/actions/python-package-shared-setup
9191
with:
9292
rye-version: ${{ vars.RYE_VERSION }}
93-
python-version: '3.8'
93+
python-version: '3.9'
9494
- name: Create build
9595
id: create-build
9696
working-directory: libs/${{ matrix.package }}

.github/workflows/publish.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,6 @@ jobs:
7171
fail-fast: false
7272
matrix:
7373
include:
74-
- python-version: 3.8
75-
prod-key: PROD_LABELBOX_API_KEY_2
76-
da-test-key: DA_GCP_LABELBOX_API_KEY
7774
- python-version: 3.9
7875
prod-key: PROD_LABELBOX_API_KEY_3
7976
da-test-key: DA_GCP_LABELBOX_API_KEY

.github/workflows/python-package-develop.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
- name: Get Latest SDK versions
4545
id: get_sdk_versions
4646
run: |
47-
sdk_versions=$(git tag --list --sort=-version:refname "v.*" | head -n 4 | jq -R -s -c 'split("\n")[:-1]')
47+
sdk_versions=$(git tag --list --sort=-version:refname "v.*" | head -n 3 | jq -R -s -c 'split("\n")[:-1]')
4848
if [ -z "$sdk_versions" ]; then
4949
echo "No tags found"
5050
exit 1
@@ -58,10 +58,6 @@ jobs:
5858
fail-fast: false
5959
matrix:
6060
include:
61-
- python-version: 3.8
62-
api-key: STAGING_LABELBOX_API_KEY_2
63-
da-test-key: DA_GCP_LABELBOX_API_KEY
64-
sdk-version: ${{ fromJson(needs.get_sdk_versions.outputs.sdk_versions)[3] }}
6561
- python-version: 3.9
6662
api-key: STAGING_LABELBOX_API_KEY_3
6763
da-test-key: DA_GCP_LABELBOX_API_KEY
@@ -103,7 +99,7 @@ jobs:
10399
- uses: ./.github/actions/python-package-shared-setup
104100
with:
105101
rye-version: ${{ vars.RYE_VERSION }}
106-
python-version: '3.8'
102+
python-version: '3.9'
107103
- name: Create build
108104
id: create-build
109105
working-directory: libs/labelbox

.github/workflows/python-package-prod.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ jobs:
1313
fail-fast: false
1414
matrix:
1515
include:
16-
- python-version: 3.8
17-
api-key: PROD_LABELBOX_API_KEY_2
18-
da-test-key: DA_GCP_LABELBOX_API_KEY
1916
- python-version: 3.9
2017
api-key: PROD_LABELBOX_API_KEY_3
2118
da-test-key: DA_GCP_LABELBOX_API_KEY

.python-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.8.18
1+
3.9.18

examples/pyproject.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ description = "Labelbox Python Example Notebooks"
55
authors = [{ name = "Labelbox", email = "docs@labelbox.com" }]
66
readme = "README.md"
77
# Python version matches labelbox SDK
8-
requires-python = ">=3.8"
8+
requires-python = ">=3.9"
99
dependencies = []
1010

1111
[project.urls]
@@ -22,8 +22,8 @@ dev-dependencies = [
2222
"yapf>=0.40.2",
2323
"black[jupyter]>=24.4.2",
2424
"databooks>=1.3.10",
25-
# higher versions dont support python 3.8
26-
"pandas>=2.0.3",
25+
# higher versions dont support python 3.9
26+
"pandas>=2.2.3",
2727
]
2828

2929
[tool.rye.scripts]

libs/labelbox/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# https://github.com/ucyo/python-package-template/blob/master/Dockerfile
2-
FROM python:3.8-slim as rye
2+
FROM python:3.9-slim as rye
33

44
ENV LANG="C.UTF-8" \
55
LC_ALL="C.UTF-8" \
@@ -38,7 +38,7 @@ WORKDIR /home/python/labelbox-python
3838

3939
RUN rye config --set-bool behavior.global-python=true && \
4040
rye config --set-bool behavior.use-uv=true && \
41-
rye pin 3.8 && \
41+
rye pin 3.9 && \
4242
rye sync
4343

4444
CMD cd libs/labelbox && rye run integration && rye sync -f --features labelbox/data && rye run unit && rye run data

libs/labelbox/pyproject.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ dependencies = [
1515
"lbox-clients==1.1.0",
1616
]
1717
readme = "README.md"
18-
requires-python = ">=3.8"
18+
requires-python = ">=3.9"
1919
classifiers = [
2020
# How mature is this project?
2121
"Development Status :: 5 - Production/Stable",
@@ -29,7 +29,6 @@ classifiers = [
2929
"License :: OSI Approved :: Apache Software License",
3030
# Specify the Python versions you support here.
3131
"Programming Language :: Python :: 3",
32-
"Programming Language :: Python :: 3.8",
3332
"Programming Language :: Python :: 3.9",
3433
"Programming Language :: Python :: 3.10",
3534
"Programming Language :: Python :: 3.11",
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
from typing_extensions import Annotated
1+
from typing import Annotated
22

33
from pydantic import Field
44

5-
65
Cuid = Annotated[str, Field(min_length=25, max_length=25)]

0 commit comments

Comments
 (0)