More defensive programming on input

Author: Adrian Chang

libs/labelbox/src/labelbox/schema/user_group.py

@@ -110,7 +110,10 @@ def get(self) -> "UserGroup":
 
         Raises:
             ResourceNotFoundError: If the query fails to fetch the group information.
+            ValueError: If the group ID is not provided.
         """
+        if not self.id:
+            raise ValueError("Group id is required")
         query = """
             query GetUserGroupPyApi($id: ID!) {
                 userGroup(where: {id: $id}) {
@@ -156,7 +159,12 @@ def update(self) -> "UserGroup":
         Raises:
             ResourceNotFoundError: If the update fails due to unknown user group
             UnprocessableEntityError: If the update fails due to a malformed input
+            ValueError: If the group id or name is not provided
         """
+        if not self.id:
+            raise ValueError("Group id is required")
+        if not self.name:
+            raise ValueError("Group name is required")
         query = """
         mutation UpdateUserGroupPyApi($id: ID!, $name: String!, $color: String!, $projectIds: [String!]!, $userIds: [String!]!) {
             updateUserGroup(

libs/labelbox/tests/unit/schema/test_user_group.py

@@ -65,6 +65,13 @@ def test_constructor(self):
         assert len(group.projects) == 0
         assert len(group.users) == 0
 
+    def test_update_with_exception_name(self):
+        group = self.group
+        group.id = ""
+
+        with pytest.raises(ValueError):
+            group.get()
+
     def test_get(self):
         projects = [
             {
@@ -170,6 +177,20 @@ def test_update_resource_error_unknown_id(self):
         with pytest.raises(ResourceNotFoundError) as e:
             group.update()
 
+    def test_update_with_exception_name(self):
+        group = self.group
+        group.name = ""
+
+        with pytest.raises(ValueError):
+            group.update()
+
+    def test_update_with_exception_name(self):
+        group = self.group
+        group.id = ""
+
+        with pytest.raises(ValueError):
+            group.update()
+
     def test_create_with_exception_id(self):
         group = self.group
         group.id = "group_id"