Fix metrics serialization

Author: Val Brodsky

libs/labelbox/src/labelbox/data/serialization/ndjson/metric.py

@@ -56,7 +56,7 @@ def from_common(
 
 class NDScalarMetric(BaseNDMetric):
     metric_value: Union[ScalarMetricValue, ScalarMetricConfidenceValue]
-    metric_name: Optional[str]
+    metric_name: Optional[str] = None
     aggregation: ScalarMetricAggregation = ScalarMetricAggregation.ARITHMETIC_MEAN
 
     def to_common(self) -> ScalarMetric:

libs/labelbox/tests/data/assets/ndjson/classification_import_global_key.json

@@ -1,54 +1,46 @@
-[
-    {
-        "answer": {
-            "schemaId": "ckrb1sfl8099g0y91cxbd5ftb",
-            "confidence": 0.8,
-            "customMetrics": [
-                {
-                    "name": "customMetric1",
-                    "value": 0.5
-                },
-                {
-                    "name": "customMetric2",
-                    "value": 0.3
-                }
-            ]
-        },
-        "schemaId": "c123",
-        "dataRow": {
-            "globalKey": "05e8ee85-072e-4eb2-b30a-501dee9b0d9d"
-        },
-        "uuid": "f6879f59-d2b5-49c2-aceb-d9e8dc478673"
+[{
+    "answer": {
+        "schemaId":
+            "ckrb1sfl8099g0y91cxbd5ftb",
+        "confidence":
+            0.8,
+        "customMetrics": [{
+            "name": "customMetric1",
+            "value": 0.5
+        }, {
+            "name": "customMetric2",
+            "value": 0.3
+        }]
     },
-    {
-        "answer": [
-            {
-                "schemaId": "ckrb1sfl8099e0y919v260awv",
-                "confidence": 0.82,
-                "customMetrics": [
-                    {
-                        "name": "customMetric1",
-                        "value": 0.5
-                    },
-                    {
-                        "name": "customMetric2",
-                        "value": 0.3
-                    }
-                ]
-            }
-        ],
-        "schemaId": "ckrb1sfkn099c0y910wbo0p1a",
-        "dataRow": {
-            "globalKey": "05e8ee85-072e-4eb2-b30a-501dee9b0d9d"
-        },
-        "uuid": "d009925d-91a3-4f67-abd9-753453f5a584"
+    "schemaId": "clxfaavvs00000cl9ai9i3etn",
+    "dataRow": {
+        "globalKey": "05e8ee85-072e-4eb2-b30a-501dee9b0d9d"
     },
-    {
-        "answer": "a value",
-        "schemaId": "ckrb1sfkn099c0y910wbo0p1a",
-        "dataRow": {
-            "globalKey": "05e8ee85-072e-4eb2-b30a-501dee9b0d9d"
-        },
-        "uuid": "ee70fd88-9f88-48dd-b760-7469ff479b71"
-    }
-]
+    "uuid": "f6879f59-d2b5-49c2-aceb-d9e8dc478673"
+}, {
+    "answer": [{
+        "schemaId":
+            "ckrb1sfl8099e0y919v260awv",
+        "confidence":
+            0.82,
+        "customMetrics": [{
+            "name": "customMetric1",
+            "value": 0.5
+        }, {
+            "name": "customMetric2",
+            "value": 0.3
+        }]
+    }],
+    "schemaId": "ckrb1sfkn099c0y910wbo0p1a",
+    "dataRow": {
+        "globalKey": "05e8ee85-072e-4eb2-b30a-501dee9b0d9d"
+    },
+    "uuid": "d009925d-91a3-4f67-abd9-753453f5a584"
+}, {
+    "answer": "a value",
+    "schemaId": "ckrb1sfkn099c0y910wbo0p1a",
+    "dataRow": {
+        "globalKey": "05e8ee85-072e-4eb2-b30a-501dee9b0d9d"
+    },
+    "uuid": "ee70fd88-9f88-48dd-b760-7469ff479b71"
+}]

libs/labelbox/tests/data/serialization/ndjson/test_global_key.py

@@ -5,6 +5,7 @@
 
 from labelbox.data.serialization.ndjson.converter import NDJsonConverter
 from labelbox.data.serialization.ndjson.objects import NDLine
+from labelbox.data.annotation_types.metrics.scalar import ScalarMetricAggregation
 
 
 def round_dict(data):
@@ -21,8 +22,21 @@ def round_dict(data):
 
 
 @pytest.mark.parametrize('filename', [
-    'tests/data/assets/ndjson/classification_import_global_key.json',
     'tests/data/assets/ndjson/metric_import_global_key.json',
+])
+def test_metric_import(filename: str):
+    with open(filename, 'r') as f:
+        data = json.load(f)
+    res = list(NDJsonConverter.deserialize(data))
+    res = list(NDJsonConverter.serialize(res))
+
+    data[0]['aggregation'] = ScalarMetricAggregation.ARITHMETIC_MEAN.name
+    assert res == data
+    f.close()
+
+
+@pytest.mark.parametrize('filename', [
+    'tests/data/assets/ndjson/classification_import_global_key.json',
     'tests/data/assets/ndjson/polyline_import_global_key.json',
     'tests/data/assets/ndjson/text_entity_import_global_key.json',
     'tests/data/assets/ndjson/conversation_entity_import_global_key.json',
@@ -32,6 +46,7 @@ def test_many_types(filename: str):
         data = json.load(f)
     res = list(NDJsonConverter.deserialize(data))
     res = list(NDJsonConverter.serialize(res))
+
     assert res == data
     f.close()