Skip to content

Commit 1ada7be

Browse files
author
Val Brodsky
committed
Removed queue_mode
1 parent 8a36b7b commit 1ada7be

File tree

10 files changed

+47
-95
lines changed

10 files changed

+47
-95
lines changed

libs/labelbox/src/labelbox/project_validation.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class _CoreProjectInput(BaseModel):
4040
def validate_fields(self):
4141
if (
4242
self.auto_audit_percentage is not None
43-
and self.auto_audit_number_of_labels is not None
43+
or self.auto_audit_number_of_labels is not None
4444
):
4545
raise ValueError(
4646
"quality_modes must be set instead of auto_audit_percentage or auto_audit_number_of_labels."
@@ -67,9 +67,8 @@ def validate_fields(self):
6767
)
6868
elif self.quality_modes == {QualityMode.Consensus}:
6969
self._set_quality_mode_attributes(
70-
data,
71-
CONSENSUS_AUTO_AUDIT_NUMBER_OF_LABELS,
72-
CONSENSUS_AUTO_AUDIT_PERCENTAGE,
70+
number_of_labels=CONSENSUS_AUTO_AUDIT_NUMBER_OF_LABELS,
71+
percentage=CONSENSUS_AUTO_AUDIT_PERCENTAGE,
7372
is_consensus_enabled=True,
7473
)
7574

libs/labelbox/tests/conftest.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
from labelbox.schema.ontology import Ontology
3333
from labelbox.schema.project import Project
3434
from labelbox.schema.quality_mode import QualityMode
35-
from labelbox.schema.queue_mode import QueueMode
3635

3736
IMG_URL = "https://picsum.photos/200/300.jpg"
3837
MASKABLE_IMG_URL = "https://storage.googleapis.com/labelbox-datasets/image_sample_data/2560px-Kitano_Street_Kobe01s5s4110.jpeg"
@@ -444,7 +443,6 @@ def conversation_entity_data_row(client, rand_gen):
444443
def project(client, rand_gen):
445444
project = client.create_project(
446445
name=rand_gen(str),
447-
queue_mode=QueueMode.Batch,
448446
media_type=MediaType.Image,
449447
)
450448
yield project
@@ -455,8 +453,7 @@ def project(client, rand_gen):
455453
def consensus_project(client, rand_gen):
456454
project = client.create_project(
457455
name=rand_gen(str),
458-
quality_mode=QualityMode.Consensus,
459-
queue_mode=QueueMode.Batch,
456+
quality_modes={QualityMode.Consensus},
460457
media_type=MediaType.Image,
461458
)
462459
yield project
@@ -646,7 +643,6 @@ def configured_project_with_label(
646643
"""
647644
project = client.create_project(
648645
name=rand_gen(str),
649-
queue_mode=QueueMode.Batch,
650646
media_type=MediaType.Image,
651647
)
652648
project._wait_until_data_rows_are_processed(
@@ -749,7 +745,6 @@ def configured_batch_project_with_label(
749745
"""
750746
project = client.create_project(
751747
name=rand_gen(str),
752-
queue_mode=QueueMode.Batch,
753748
media_type=MediaType.Image,
754749
)
755750
data_rows = [dr.uid for dr in list(dataset.data_rows())]
@@ -784,7 +779,6 @@ def configured_batch_project_with_multiple_datarows(
784779
"""
785780
project = client.create_project(
786781
name=rand_gen(str),
787-
queue_mode=QueueMode.Batch,
788782
media_type=MediaType.Image,
789783
)
790784
global_keys = [dr.global_key for dr in data_rows]
@@ -1065,7 +1059,6 @@ def configured_project_with_complex_ontology(
10651059
):
10661060
project = client.create_project(
10671061
name=rand_gen(str),
1068-
queue_mode=QueueMode.Batch,
10691062
media_type=MediaType.Image,
10701063
)
10711064
dataset = initial_dataset

libs/labelbox/tests/data/export/conftest.py

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from labelbox.schema.annotation_import import AnnotationImportState, LabelImport
77
from labelbox.schema.labeling_frontend import LabelingFrontend
88
from labelbox.schema.media_type import MediaType
9-
from labelbox.schema.queue_mode import QueueMode
109

1110

1211
@pytest.fixture
@@ -249,7 +248,6 @@ def configured_project_with_ontology(
249248
dataset = initial_dataset
250249
project = client.create_project(
251250
name=rand_gen(str),
252-
queue_mode=QueueMode.Batch,
253251
media_type=MediaType.Image,
254252
)
255253
editor = list(
@@ -277,7 +275,6 @@ def configured_project_without_data_rows(
277275
project = client.create_project(
278276
name=rand_gen(str),
279277
description=rand_gen(str),
280-
queue_mode=QueueMode.Batch,
281278
media_type=MediaType.Image,
282279
)
283280
editor = list(
@@ -288,6 +285,23 @@ def configured_project_without_data_rows(
288285
teardown_helpers.teardown_project_labels_ontology_feature_schemas(project)
289286

290287

288+
@pytest.fixture
289+
def configured_video_project_without_data_rows(
290+
client, ontology, rand_gen, teardown_helpers
291+
):
292+
project = client.create_project(
293+
name=rand_gen(str),
294+
description=rand_gen(str),
295+
media_type=MediaType.Video,
296+
)
297+
editor = list(
298+
client.get_labeling_frontends(where=LabelingFrontend.name == "editor")
299+
)[0]
300+
project.setup(editor, ontology)
301+
yield project
302+
teardown_helpers.teardown_project_labels_ontology_feature_schemas(project)
303+
304+
291305
@pytest.fixture
292306
def model_run_with_data_rows(
293307
client,

libs/labelbox/tests/data/export/streamable/test_export_video_streamable.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ def org_id(self, client):
2121
def test_export(
2222
self,
2323
client,
24-
configured_project_without_data_rows,
24+
configured_video_project_without_data_rows,
2525
video_data,
2626
video_data_row,
2727
bbox_video_annotation_objects,
2828
rand_gen,
2929
):
30-
project = configured_project_without_data_rows
30+
project = configured_video_project_without_data_rows
3131
project_id = project.uid
3232
labels = []
3333

libs/labelbox/tests/integration/conftest.py

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,40 @@
1-
from collections import defaultdict
2-
from itertools import islice
31
import json
42
import os
5-
import sys
63
import re
4+
import sys
75
import time
86
import uuid
9-
import requests
10-
from types import SimpleNamespace
11-
from typing import Type, List
7+
from collections import defaultdict
128
from enum import Enum
13-
from typing import Tuple
9+
from itertools import islice
10+
from types import SimpleNamespace
11+
from typing import List, Tuple, Type
1412

1513
import pytest
1614
import requests
1715

18-
from labelbox import Dataset, DataRow
19-
from labelbox import LabelingFrontend
2016
from labelbox import (
21-
OntologyBuilder,
22-
Tool,
23-
Option,
2417
Classification,
18+
Client,
19+
DataRow,
20+
Dataset,
21+
LabelingFrontend,
2522
MediaType,
23+
OntologyBuilder,
24+
Option,
2625
PromptResponseClassification,
2726
ResponseOption,
27+
Tool,
2828
)
2929
from labelbox.orm import query
3030
from labelbox.pagination import PaginatedCollection
3131
from labelbox.schema.annotation_import import LabelImport
3232
from labelbox.schema.catalog import Catalog
3333
from labelbox.schema.enums import AnnotationImportState
3434
from labelbox.schema.invite import Invite
35+
from labelbox.schema.ontology_kind import OntologyKind
3536
from labelbox.schema.quality_mode import QualityMode
36-
from labelbox.schema.queue_mode import QueueMode
3737
from labelbox.schema.user import User
38-
from labelbox import Client
39-
from labelbox.schema.ontology_kind import OntologyKind
4038

4139

4240
@pytest.fixture
@@ -69,7 +67,6 @@ def project_pack(client):
6967
projects = [
7068
client.create_project(
7169
name=f"user-proj-{idx}",
72-
queue_mode=QueueMode.Batch,
7370
media_type=MediaType.Image,
7471
)
7572
for idx in range(2)
@@ -117,7 +114,6 @@ def configured_project_with_complex_ontology(
117114
):
118115
project = client.create_project(
119116
name=rand_gen(str),
120-
queue_mode=QueueMode.Batch,
121117
media_type=MediaType.Image,
122118
)
123119
dataset = initial_dataset

libs/labelbox/tests/integration/test_client_errors.py

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -81,34 +81,6 @@ def test_network_error(client):
8181
client.create_project(name="Project name", media_type=MediaType.Image)
8282

8383

84-
def test_invalid_attribute_error(
85-
client,
86-
rand_gen,
87-
):
88-
# Creation
89-
with pytest.raises(lbox.exceptions.InvalidAttributeError) as excinfo:
90-
client.create_project(
91-
name="Name", invalid_field="Whatever", media_type=MediaType.Image
92-
)
93-
assert excinfo.value.db_object_type == Project
94-
assert excinfo.value.field == "invalid_field"
95-
96-
# Update
97-
project = client.create_project(
98-
name=rand_gen(str), media_type=MediaType.Image
99-
)
100-
with pytest.raises(lbox.exceptions.InvalidAttributeError) as excinfo:
101-
project.update(invalid_field="Whatever")
102-
assert excinfo.value.db_object_type == Project
103-
assert excinfo.value.field == "invalid_field"
104-
105-
# Top-level-fetch
106-
with pytest.raises(lbox.exceptions.InvalidAttributeError) as excinfo:
107-
client.get_projects(where=User.email == "email")
108-
assert excinfo.value.db_object_type == Project
109-
assert excinfo.value.field == {User.email}
110-
111-
11284
@pytest.mark.skip("timeouts cause failure before rate limit")
11385
def test_api_limit_error(client):
11486
def get(arg):

libs/labelbox/tests/integration/test_filtering.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
import pytest
22
from lbox.exceptions import InvalidQueryError
3-
from libs.labelbox.src.labelbox.schema.media_type import MediaType
43

54
from labelbox import Project
6-
from labelbox.schema import media_type
7-
from labelbox.schema.queue_mode import QueueMode
5+
from labelbox.schema.media_type import MediaType
86

97

108
@pytest.fixture
Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,10 @@
1+
from os import name
2+
13
import pytest
4+
from pydantic import ValidationError
25

36
from labelbox.schema import media_type
47
from labelbox.schema.media_type import MediaType
5-
from labelbox.schema.queue_mode import QueueMode
6-
7-
8-
def test_project_dataset(client, rand_gen):
9-
with pytest.raises(
10-
ValueError,
11-
match="Dataset queue mode is deprecated. Please prefer Batch queue mode.",
12-
):
13-
client.create_project(
14-
name=rand_gen(str),
15-
queue_mode=QueueMode.Dataset,
16-
media_type=MediaType.Image,
17-
)
188

199

2010
def test_project_auto_audit_parameters(client, rand_gen):
@@ -29,7 +19,7 @@ def test_project_auto_audit_parameters(client, rand_gen):
2919
)
3020

3121
with pytest.raises(
32-
ValueError,
22+
ValidationError,
3323
match="quality_modes must be set instead of auto_audit_percentage or auto_audit_number_of_labels.",
3424
):
3525
client.create_project(
@@ -41,11 +31,6 @@ def test_project_auto_audit_parameters(client, rand_gen):
4131

4232
def test_project_name_parameter(client, rand_gen):
4333
with pytest.raises(
44-
ValueError, match="project name must be a valid string."
45-
):
46-
client.create_project()
47-
48-
with pytest.raises(
49-
ValueError, match="project name must be a valid string."
34+
ValidationError, match="project name must be a valid string"
5035
):
51-
client.create_project(name=" ")
36+
client.create_project(name=" ", media_type=MediaType.Image)

libs/labelbox/tests/integration/test_ontology.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
1-
import pytest
2-
3-
from labelbox import OntologyBuilder, MediaType, Tool
4-
from labelbox.orm.model import Entity
51
import json
62
import time
73

8-
from labelbox.schema.queue_mode import QueueMode
4+
import pytest
5+
6+
from labelbox import MediaType, OntologyBuilder, Tool
7+
from labelbox.orm.model import Entity
98

109

1110
def test_feature_schema_is_not_archived(client, ontology):
@@ -99,7 +98,6 @@ def test_deletes_an_ontology(client):
9998
def test_cant_delete_an_ontology_with_project(client):
10099
project = client.create_project(
101100
name="test project",
102-
queue_mode=QueueMode.Batch,
103101
media_type=MediaType.Image,
104102
)
105103
tool = client.upsert_feature_schema(point.asdict())
@@ -187,7 +185,6 @@ def test_does_not_include_used_ontologies(client):
187185
)
188186
project = client.create_project(
189187
name="test project",
190-
queue_mode=QueueMode.Batch,
191188
media_type=MediaType.Image,
192189
)
193190
project.connect_ontology(ontology_with_project)

libs/labelbox/tests/integration/test_project.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,12 @@
1010
from labelbox.schema import media_type
1111
from labelbox.schema.media_type import MediaType
1212
from labelbox.schema.quality_mode import QualityMode
13-
from labelbox.schema.queue_mode import QueueMode
1413

1514

1615
def test_project(client, rand_gen):
1716
data = {
1817
"name": rand_gen(str),
1918
"description": rand_gen(str),
20-
"queue_mode": QueueMode.Batch.Batch,
2119
"media_type": MediaType.Image,
2220
}
2321
project = client.create_project(**data)

0 commit comments

Comments
 (0)