Skip to content

Commit 1a81557

Browse files
committed
added suggestion
1 parent 548af69 commit 1a81557

File tree

1 file changed

+10
-15
lines changed

1 file changed

+10
-15
lines changed

libs/labelbox/src/labelbox/schema/ontology_kind.py

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,18 @@ def get_ontology_kind_validation_error(cls, ontology_kind):
2626
def evaluate_ontology_kind_with_media_type(ontology_kind,
2727
media_type: Optional[MediaType]) -> Union[MediaType, None]:
2828

29-
if ontology_kind and ontology_kind is OntologyKind.ModelEvaluation:
30-
if media_type is None:
31-
media_type = MediaType.Conversational
32-
else:
33-
if media_type is not MediaType.Conversational:
34-
raise ValueError(
35-
"For chat evaluation, media_type must be Conversational."
36-
)
37-
38-
elif ontology_kind == OntologyKind.ResponseCreation:
29+
ontology_to_media = {
30+
OntologyKind.ModelEvaluation: (MediaType.Conversational, "For chat evaluation, media_type must be Conversational."),
31+
OntologyKind.ResponseCreation: (MediaType.Text, "For response creation, media_type must be Text.")
32+
}
33+
34+
if ontology_kind in ontology_to_media:
35+
expected_media_type, error_message = ontology_to_media[ontology_kind]
36+
3937
if media_type is None:
40-
media_type = MediaType.Text
38+
media_type = expected_media_type
4139
else:
42-
if media_type is not MediaType.Text:
43-
raise ValueError(
44-
"For response creation, media_type must be Text."
45-
)
40+
raise ValueError(error_message)
4641

4742
return media_type
4843

0 commit comments

Comments
 (0)