Skip to content

Commit 0a355cd

Browse files
committed
review comments
1 parent a2cdae4 commit 0a355cd

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

labelbox/schema/organization.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ def get_resource_tags(self) -> List["ResourceTag"]:
142142
}
143143
}""")
144144

145-
# print(json.dumps(res['organization']['resourceTag'], indent=2, sort_keys=True))
146145
return res['organization']['resourceTag']
147146

148147
def get_iam_integrations(self) -> List["IAMIntegration"]:

labelbox/schema/project.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,10 +121,13 @@ def members(self) -> PaginatedCollection:
121121
{id_param: str(self.uid)},
122122
["project", "members"], ProjectMember)
123123

124-
def create_project_resource_tags(self, tagIdsParam) -> List["ProjectResourceTag"]:
125-
""" Creates a project resource tag
124+
def create_project_resource_tags(self, resource_tag_ids: List[str]) -> List[str]:
125+
""" Creates project resource tags
126126
127-
TODO
127+
Args:
128+
resource_tag_ids
129+
Returns:
130+
a list of ResourceTag ids that was created.
128131
"""
129132
project_id_param = "projectId"
130133
tag_ids_param = "resourceTagIds"
@@ -139,11 +142,10 @@ def create_project_resource_tags(self, tagIdsParam) -> List["ProjectResourceTag"
139142
tag_ids_param
140143
)
141144

142-
print('tagIdsParam', tagIdsParam)
143145
res = self.client.execute(
144146
query_str, {
145147
project_id_param: self.uid,
146-
tag_ids_param: tagIdsParam
148+
tag_ids_param: resource_tag_ids
147149
})
148150

149151
return res["project"]["updateProjectResourceTags"]

labelbox/schema/project_resource_tag.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ class ProjectResourceTag(DbObject, Updateable):
1111
resource_tag (Relationship): `ToOne` relationship to ResourceTag
1212
"""
1313

14-
resourceTagId = Field.ID("resourceTagId")
15-
projectId = Field.ID("projectId")
14+
resource_tag_id = Field.ID("resource_tag_id")
15+
project_id = Field.ID("project_id")

0 commit comments

Comments
 (0)