Skip to content

Commit 0246db4

Browse files
author
Val Brodsky
committed
Address QA feedback
1 parent b58e902 commit 0246db4

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

libs/labelbox/src/labelbox/schema/data_row_payload_templates.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
from typing import Dict, List
1+
from typing import Dict, List, Optional
22

33
from pydantic import BaseModel, Field
44

55
from labelbox.schema.data_row import DataRowMetadataField
66

77

8-
class ModelEvalutationTemlateRowData(BaseModel):
8+
class ModelEvalutationTemplateRowData(BaseModel):
99
type: str = Field(
1010
default="application/vnd.labelbox.conversational.model-chat-evaluation",
1111
frozen=True,
@@ -15,6 +15,7 @@ class ModelEvalutationTemlateRowData(BaseModel):
1515
actors: Dict = Field(default={})
1616
version: int = Field(default=2, frozen=True)
1717
messages: Dict = Field(default={})
18+
global_key: Optional[str] = None
1819

1920

2021
class ModelEvaluationTemplate(BaseModel):
@@ -32,8 +33,8 @@ class ModelEvaluationTemplate(BaseModel):
3233
>>> task = dataset.create_data_rows([content])
3334
"""
3435

35-
row_data: ModelEvalutationTemlateRowData = Field(
36-
default=ModelEvalutationTemlateRowData()
36+
row_data: ModelEvalutationTemplateRowData = Field(
37+
default=ModelEvalutationTemplateRowData()
3738
)
3839
attachments: List[Dict] = Field(default=[])
3940
embeddings: List[Dict] = Field(default=[])

libs/labelbox/tests/integration/test_mmc_data_rows.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
def mmc_data_row(dataset):
1111
data = ModelEvaluationTemplate()
1212

13-
content_all = data.model_dump()
13+
content_all = data.model_dump(exclude_none=True)
1414
task = dataset.create_data_rows([content_all])
1515
task.wait_till_done()
1616
assert task.status == "COMPLETE"
@@ -31,7 +31,7 @@ def mmc_data_row_all(dataset, make_metadata_fields, embedding):
3131
data.metadata_fields = make_metadata_fields
3232
data.attachments = [{"type": "RAW_TEXT", "value": "attachment value"}]
3333

34-
content_all = data.model_dump()
34+
content_all = data.model_dump(exclude_none=True)
3535
task = dataset.create_data_rows([content_all])
3636
task.wait_till_done()
3737
assert task.status == "COMPLETE"

0 commit comments

Comments
 (0)