Skip to content

Commit 01acef5

Browse files
author
Val Brodsky
committed
Fix flaky annotation test by waiting on prompt response data rows to be created
1 parent e74b5d8 commit 01acef5

File tree

2 files changed

+19
-12
lines changed

2 files changed

+19
-12
lines changed

libs/labelbox/tests/data/annotation_import/conftest.py

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -686,14 +686,21 @@ def _create_prompt_response_project(client: Client, rand_gen, media_type, normal
686686
prompt_response_project.connect_ontology(ontology)
687687

688688
# We have to export to get data row ids
689-
result = export_v2_test_helpers.run_project_export_v2_task(prompt_response_project)
690-
691-
data_row_ids = [dr["data_row"]["id"] for dr in result]
692-
global_keys = [dr["data_row"]["global_key"] for dr in result]
693-
689+
data_row_ids = []
690+
global_keys = []
691+
timeout = 0
692+
while len(data_row_ids) < 1 and timeout < 3:
693+
result = export_v2_test_helpers.run_project_export_v2_task(prompt_response_project)
694+
695+
data_row_ids.extend([dr["data_row"]["id"] for dr in result])
696+
global_keys.extend([dr["data_row"]["global_key"] for dr in result])
697+
698+
time.sleep(1)
699+
timeout += 1
700+
694701
prompt_response_project.data_row_ids = data_row_ids
695702
prompt_response_project.global_keys = global_keys
696-
703+
697704
return prompt_response_project, ontology
698705

699706
def _create_project(client: Client, rand_gen, data_row_json_by_media_type, media_type, normalized_ontology_by_media_type) -> Tuple[Project, Ontology, Dataset]:

libs/labelbox/tests/data/annotation_import/test_generic_data_types.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ def test_generic_data_row_type_by_data_row_id(
6666
(MediaType.Video, GenericDataRowData),
6767
(MediaType.Conversational, GenericDataRowData),
6868
(MediaType.Document, GenericDataRowData),
69-
# (MediaType.LLMPromptResponseCreation, GenericDataRowData),
70-
# (MediaType.LLMPromptCreation, GenericDataRowData),
69+
(MediaType.LLMPromptResponseCreation, GenericDataRowData),
70+
(MediaType.LLMPromptCreation, GenericDataRowData),
7171
(OntologyKind.ResponseCreation, GenericDataRowData)
7272
],
7373
)
@@ -100,8 +100,8 @@ def test_generic_data_row_type_by_global_key(
100100
(MediaType.Conversational, MediaType.Conversational),
101101
(MediaType.Document, MediaType.Document),
102102
(MediaType.Dicom, MediaType.Dicom),
103-
# (MediaType.LLMPromptResponseCreation, MediaType.LLMPromptResponseCreation),
104-
# (MediaType.LLMPromptCreation, MediaType.LLMPromptCreation),
103+
(MediaType.LLMPromptResponseCreation, MediaType.LLMPromptResponseCreation),
104+
(MediaType.LLMPromptCreation, MediaType.LLMPromptCreation),
105105
(OntologyKind.ResponseCreation, OntologyKind.ResponseCreation)
106106
],
107107
indirect=["configured_project"]
@@ -220,8 +220,8 @@ def test_import_media_types_by_global_key(
220220
(MediaType.Conversational, MediaType.Conversational),
221221
(MediaType.Document, MediaType.Document),
222222
(MediaType.Dicom, MediaType.Dicom),
223-
# (MediaType.LLMPromptResponseCreation, MediaType.LLMPromptResponseCreation),
224-
# (MediaType.LLMPromptCreation, MediaType.LLMPromptCreation),
223+
(MediaType.LLMPromptResponseCreation, MediaType.LLMPromptResponseCreation),
224+
(MediaType.LLMPromptCreation, MediaType.LLMPromptCreation),
225225
(OntologyKind.ResponseCreation, OntologyKind.ResponseCreation)
226226
],
227227
indirect=["configured_project"]

0 commit comments

Comments
 (0)